Re: [Intel-gfx] [PATCH 2/4] [v3] drm/i915: cleanup map&fence in bind

2013-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2013 at 10:27:42AM -0700, Ben Widawsky wrote: > On Wed, Aug 14, 2013 at 10:18:55AM +0200, Daniel Vetter wrote: > > On Tue, Aug 13, 2013 at 06:09:07PM -0700, Ben Widawsky wrote: > > > Cleanup the map and fenceable setting during bind to make more sense, > > > and not check i915_is_gg

Re: [Intel-gfx] [PATCH 2/4] [v3] drm/i915: cleanup map&fence in bind

2013-08-14 Thread Ben Widawsky
On Wed, Aug 14, 2013 at 10:18:55AM +0200, Daniel Vetter wrote: > On Tue, Aug 13, 2013 at 06:09:07PM -0700, Ben Widawsky wrote: > > Cleanup the map and fenceable setting during bind to make more sense, > > and not check i915_is_ggtt() 2 unnecessary times > > > > v2: Move the bools into the if block

Re: [Intel-gfx] [PATCH 2/4] [v3] drm/i915: cleanup map&fence in bind

2013-08-14 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 06:09:07PM -0700, Ben Widawsky wrote: > Cleanup the map and fenceable setting during bind to make more sense, > and not check i915_is_ggtt() 2 unnecessary times > > v2: Move the bools into the if block (Chris) - There are ways to tidy > this function (fence calculations for

[Intel-gfx] [PATCH 2/4] [v3] drm/i915: cleanup map&fence in bind

2013-08-13 Thread Ben Widawsky
Cleanup the map and fenceable setting during bind to make more sense, and not check i915_is_ggtt() 2 unnecessary times v2: Move the bools into the if block (Chris) - There are ways to tidy this function (fence calculations for instance) even further, but they are quite invasive, so I am punting on