Re: [Intel-gfx] [PATCH 2/3] i915: Rename PIPE_CONTROL bit defines to be less terse.

2011-10-05 Thread Ben Widawsky
On Mon, Oct 03, 2011 at 11:02:39PM -0700, Kenneth Graunke wrote: > "STALL_AT_SCOREBOARD" is much clearer than "STALL_EN" now that there are > several different kinds of stalls. Also, "INSTRUCTION_CACHE_FLUSH" is a > lot easier to understand at a glance than the terse "IS_FLUSH." > > Signed-off-by

Re: [Intel-gfx] [PATCH 2/3] i915: Rename PIPE_CONTROL bit defines to be less terse.

2011-10-05 Thread Daniel Vetter
On Tue, Oct 04, 2011 at 10:13:47PM -0700, Kenneth Graunke wrote: > On 10/04/2011 01:30 AM, Daniel Vetter wrote: > > On Mon, Oct 03, 2011 at 11:02:39PM -0700, Kenneth Graunke wrote: > >> "STALL_AT_SCOREBOARD" is much clearer than "STALL_EN" now that there are > >> several different kinds of stalls.

Re: [Intel-gfx] [PATCH 2/3] i915: Rename PIPE_CONTROL bit defines to be less terse.

2011-10-04 Thread Kenneth Graunke
On 10/04/2011 01:30 AM, Daniel Vetter wrote: > On Mon, Oct 03, 2011 at 11:02:39PM -0700, Kenneth Graunke wrote: >> "STALL_AT_SCOREBOARD" is much clearer than "STALL_EN" now that there are >> several different kinds of stalls. Also, "INSTRUCTION_CACHE_FLUSH" is a >> lot easier to understand at a gl

Re: [Intel-gfx] [PATCH 2/3] i915: Rename PIPE_CONTROL bit defines to be less terse.

2011-10-04 Thread Daniel Vetter
On Mon, Oct 03, 2011 at 11:02:39PM -0700, Kenneth Graunke wrote: > "STALL_AT_SCOREBOARD" is much clearer than "STALL_EN" now that there are > several different kinds of stalls. Also, "INSTRUCTION_CACHE_FLUSH" is a > lot easier to understand at a glance than the terse "IS_FLUSH." > > Signed-off-by

[Intel-gfx] [PATCH 2/3] i915: Rename PIPE_CONTROL bit defines to be less terse.

2011-10-03 Thread Kenneth Graunke
"STALL_AT_SCOREBOARD" is much clearer than "STALL_EN" now that there are several different kinds of stalls. Also, "INSTRUCTION_CACHE_FLUSH" is a lot easier to understand at a glance than the terse "IS_FLUSH." Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/i915_reg.h | 16