Re: [Intel-gfx] [PATCH 2/3] drm/i915: unify GT/PM irq postinstall code

2013-07-15 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 05:13:34PM -0700, Ben Widawsky wrote: > On Sun, Jul 14, 2013 at 11:31:29PM +0200, Daniel Vetter wrote: > > On Sun, Jul 14, 2013 at 01:55:20PM -0700, Ben Widawsky wrote: > > > On Fri, Jul 12, 2013 at 10:43:26PM +0200, Daniel Vetter wrote: > [snip] > > > > > > > Maybe while

Re: [Intel-gfx] [PATCH 2/3] drm/i915: unify GT/PM irq postinstall code

2013-07-14 Thread Ben Widawsky
On Sun, Jul 14, 2013 at 11:31:29PM +0200, Daniel Vetter wrote: > On Sun, Jul 14, 2013 at 01:55:20PM -0700, Ben Widawsky wrote: > > On Fri, Jul 12, 2013 at 10:43:26PM +0200, Daniel Vetter wrote: [snip] > > > > Maybe while you're doing this, explain why the L3 parity interrupt is > > special, in a

Re: [Intel-gfx] [PATCH 2/3] drm/i915: unify GT/PM irq postinstall code

2013-07-14 Thread Ben Widawsky
On Sun, Jul 14, 2013 at 11:31:29PM +0200, Daniel Vetter wrote: > On Sun, Jul 14, 2013 at 01:55:20PM -0700, Ben Widawsky wrote: > > On Fri, Jul 12, 2013 at 10:43:26PM +0200, Daniel Vetter wrote: > > > Again extract a common helper. For the postinstall hook things are a > > > bit more complicated sin

Re: [Intel-gfx] [PATCH 2/3] drm/i915: unify GT/PM irq postinstall code

2013-07-14 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 01:55:20PM -0700, Ben Widawsky wrote: > On Fri, Jul 12, 2013 at 10:43:26PM +0200, Daniel Vetter wrote: > > Again extract a common helper. For the postinstall hook things are a > > bit more complicated since we have more cases on ilk-hsw/vlv here. > > > > But since vlv was c

Re: [Intel-gfx] [PATCH 2/3] drm/i915: unify GT/PM irq postinstall code

2013-07-14 Thread Ben Widawsky
On Fri, Jul 12, 2013 at 10:43:26PM +0200, Daniel Vetter wrote: > Again extract a common helper. For the postinstall hook things are a > bit more complicated since we have more cases on ilk-hsw/vlv here. > > But since vlv was clearly broken by failing to initialize > dev_priv->gt_irq_mask correctly

[Intel-gfx] [PATCH 2/3] drm/i915: unify GT/PM irq postinstall code

2013-07-12 Thread Daniel Vetter
Again extract a common helper. For the postinstall hook things are a bit more complicated since we have more cases on ilk-hsw/vlv here. But since vlv was clearly broken by failing to initialize dev_priv->gt_irq_mask correctly the shared code is clearly justified. Also kill the PMIER setting in th