Re: [Intel-gfx] [PATCH 2/3] drm/i915: remove potentially confusing IS_G4X checks

2017-02-21 Thread Ville Syrjälä
On Mon, Feb 20, 2017 at 05:00:41PM -0300, Paulo Zanoni wrote: > The IS_G4X macro is defined as IS_G45 || IS_GM45. We have two points > in our code where we have an if statement checking for GM45 followed > by an else if statement checking for IS_G4X. This can be confusing > since the IS_G4X check w

[Intel-gfx] [PATCH 2/3] drm/i915: remove potentially confusing IS_G4X checks

2017-02-20 Thread Paulo Zanoni
The IS_G4X macro is defined as IS_G45 || IS_GM45. We have two points in our code where we have an if statement checking for GM45 followed by an else if statement checking for IS_G4X. This can be confusing since the IS_G4X check won't be catching the previously-checked GM45. Someone quickly trying t