Re: [Intel-gfx] [PATCH 2/3] drm/i915: prefer FORCE_WC for the blitter routines

2021-01-18 Thread Chris Wilson
Quoting Matthew Auld (2021-01-18 15:55:31) > On Mon, 18 Jan 2021 at 14:54, Chris Wilson wrote: > > > > Quoting Matthew Auld (2021-01-18 14:17:31) > > > From: CQ Tang > > > > > > The pool is shared and so we might find that there is a pool object with > > > an existing mapping, but is mapped with

Re: [Intel-gfx] [PATCH 2/3] drm/i915: prefer FORCE_WC for the blitter routines

2021-01-18 Thread Matthew Auld
On Mon, 18 Jan 2021 at 14:54, Chris Wilson wrote: > > Quoting Matthew Auld (2021-01-18 14:17:31) > > From: CQ Tang > > > > The pool is shared and so we might find that there is a pool object with > > an existing mapping, but is mapped with different underlying type, which > > will result in -EBUS

Re: [Intel-gfx] [PATCH 2/3] drm/i915: prefer FORCE_WC for the blitter routines

2021-01-18 Thread Chris Wilson
Quoting Matthew Auld (2021-01-18 14:17:31) > From: CQ Tang > > The pool is shared and so we might find that there is a pool object with > an existing mapping, but is mapped with different underlying type, which > will result in -EBUSY. > > Signed-off-by: CQ Tang > Signed-off-by: Matthew Auld >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: prefer FORCE_WC for the blitter routines

2021-01-18 Thread Chris Wilson
Quoting Matthew Auld (2021-01-18 14:17:31) > From: CQ Tang First patch hasn't arrive, so excuse this misplaced reply. - if (GEM_WARN_ON(!r->sgt.pfn)) + if (GEM_WARN_ON(!use_dma(r->iobase) && !r->sgt.pfn)) return -EINVAL; The better check would be if (GEM_WARN_ON(!r->

[Intel-gfx] [PATCH 2/3] drm/i915: prefer FORCE_WC for the blitter routines

2021-01-18 Thread Matthew Auld
From: CQ Tang The pool is shared and so we might find that there is a pool object with an existing mapping, but is mapped with different underlying type, which will result in -EBUSY. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 4 ++--