Re: [Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-07-07 Thread Daniel Vetter
On Thu, Jun 19, 2014 at 11:00:20AM -0700, Jesse Barnes wrote: > Jani, can you review this one? It's still needed for us to conform to > the eDP timing spec. Jani's already goofing off on vacation and I couldn't spot his r-b. Merged anyway, I guess people will scream fast enough if this breaks stu

Re: [Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-06-26 Thread Jani Nikula
On Wed, 25 Jun 2014, Jesse Barnes wrote: > On Wed, 25 Jun 2014 15:21:12 +0300 > Jani Nikula wrote: > >> On Mon, 31 Mar 2014, Jesse Barnes wrote: >> > With the new checks in place, we can see we're doing things backwards, >> > so fix them up per the spec. >> > >> > Signed-off-by: Jesse Barnes >>

Re: [Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-06-25 Thread Jesse Barnes
On Wed, 25 Jun 2014 15:21:12 +0300 Jani Nikula wrote: > On Mon, 31 Mar 2014, Jesse Barnes wrote: > > With the new checks in place, we can see we're doing things backwards, > > so fix them up per the spec. > > > > Signed-off-by: Jesse Barnes > > --- > > drivers/gpu/drm/i915/intel_dp.c | 13

Re: [Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-06-25 Thread Jani Nikula
On Mon, 31 Mar 2014, Jesse Barnes wrote: > With the new checks in place, we can see we're doing things backwards, > so fix them up per the spec. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_dp.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff

Re: [Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-06-19 Thread Jesse Barnes
Jani, can you review this one? It's still needed for us to conform to the eDP timing spec. Thanks, Jesse On Mon, 31 Mar 2014 11:13:56 -0700 Jesse Barnes wrote: > With the new checks in place, we can see we're doing things backwards, > so fix them up per the spec. > > Signed-off-by: Jesse Barn

[Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-03-31 Thread Jesse Barnes
With the new checks in place, we can see we're doing things backwards, so fix them up per the spec. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_dp.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/