Re: [Intel-gfx] [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing

2012-02-08 Thread Daniel Vetter
On Wed, Feb 08, 2012 at 11:17:08PM +0100, Ben Widawsky wrote: > On 01/31/2012 04:47 PM, Daniel Vetter wrote: > > On gen5 we also need to correctly set up swizzling in the display > > scanout engine, but only there. Consolidate this into the same > > function. > > > > This has a small effect on ums

Re: [Intel-gfx] [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing

2012-02-08 Thread Ben Widawsky
On 01/31/2012 04:47 PM, Daniel Vetter wrote: > On gen5 we also need to correctly set up swizzling in the display > scanout engine, but only there. Consolidate this into the same > function. > > This has a small effect on ums setups - the kernel now also sets this > bit in addition to userspace set

Re: [Intel-gfx] [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing

2012-02-01 Thread Daniel Vetter
On Wed, Feb 01, 2012 at 01:37:29PM -0800, Ben Widawsky wrote: > On Tue, Jan 31, 2012 at 04:47:55PM +0100, Daniel Vetter wrote: > > On gen5 we also need to correctly set up swizzling in the display > > scanout engine, but only there. Consolidate this into the same > > function. > > > > This has a s

Re: [Intel-gfx] [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing

2012-02-01 Thread Ben Widawsky
On Tue, Jan 31, 2012 at 04:47:55PM +0100, Daniel Vetter wrote: > On gen5 we also need to correctly set up swizzling in the display > scanout engine, but only there. Consolidate this into the same > function. > > This has a small effect on ums setups - the kernel now also sets this > bit in additio

[Intel-gfx] [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing

2012-01-31 Thread Daniel Vetter
On gen5 we also need to correctly set up swizzling in the display scanout engine, but only there. Consolidate this into the same function. This has a small effect on ums setups - the kernel now also sets this bit in addition to userspace setting it. Given that this code only runs when userspace ei