Re: [Intel-gfx] [PATCH 2/3] drm/i915: add yesno utility function

2015-09-02 Thread Daniel Vetter
On Mon, Aug 31, 2015 at 03:33:13PM +0100, Chris Wilson wrote: > On Mon, Aug 31, 2015 at 05:23:27PM +0300, Jani Nikula wrote: > > On Thu, 27 Aug 2015, Jani Nikula wrote: > > > On Thu, 27 Aug 2015, Chris Wilson wrote: > > >> On Thu, Aug 27, 2015 at 04:23:30PM +0300, Jani Nikula wrote: > > >>> Add a

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add yesno utility function

2015-08-31 Thread Chris Wilson
On Mon, Aug 31, 2015 at 05:23:27PM +0300, Jani Nikula wrote: > On Thu, 27 Aug 2015, Jani Nikula wrote: > > On Thu, 27 Aug 2015, Chris Wilson wrote: > >> On Thu, Aug 27, 2015 at 04:23:30PM +0300, Jani Nikula wrote: > >>> Add a common function to return "yes" or "no" string based on the > >>> argum

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add yesno utility function

2015-08-31 Thread Jani Nikula
On Thu, 27 Aug 2015, Jani Nikula wrote: > On Thu, 27 Aug 2015, Chris Wilson wrote: >> On Thu, Aug 27, 2015 at 04:23:30PM +0300, Jani Nikula wrote: >>> Add a common function to return "yes" or "no" string based on the >>> argument, and drop the local versions of it. >> >> Purely out of curiosity,

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add yesno utility function

2015-08-27 Thread Jani Nikula
On Thu, 27 Aug 2015, Chris Wilson wrote: > On Thu, Aug 27, 2015 at 04:23:30PM +0300, Jani Nikula wrote: >> Add a common function to return "yes" or "no" string based on the >> argument, and drop the local versions of it. > > Purely out of curiosity, gcc is able to amalgamate the constant strings >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add yesno utility function

2015-08-27 Thread Chris Wilson
On Thu, Aug 27, 2015 at 04:23:30PM +0300, Jani Nikula wrote: > Add a common function to return "yes" or "no" string based on the > argument, and drop the local versions of it. Purely out of curiosity, gcc is able to amalgamate the constant strings (I remember reading that it is intelligent enough

[Intel-gfx] [PATCH 2/3] drm/i915: add yesno utility function

2015-08-27 Thread Jani Nikula
Add a common function to return "yes" or "no" string based on the argument, and drop the local versions of it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_debugfs.c | 5 - drivers/gpu/drm/i915/i915_drv.h | 5 + drivers/gpu/drm/i915/i915_gpu_error.c | 5 - 3 files