Re: [Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-18 Thread Chris Wilson
On Wed, Jun 17, 2015 at 05:47:10PM -0300, Paulo Zanoni wrote: > 2015-06-17 17:25 GMT-03:00 Chris Wilson : > > On Wed, Jun 17, 2015 at 04:39:32PM -0300, Paulo Zanoni wrote: > >> 2015-06-17 4:52 GMT-03:00 Chris Wilson : > >> > These busy bits are locked higher up. In fact I want to migrate that > >>

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-17 Thread Paulo Zanoni
2015-06-17 17:25 GMT-03:00 Chris Wilson : > On Wed, Jun 17, 2015 at 04:39:32PM -0300, Paulo Zanoni wrote: >> 2015-06-17 4:52 GMT-03:00 Chris Wilson : >> > These busy bits are locked higher up. In fact I want to migrate that >> > lock to a spinlock, which has implications here. I didn't see anything

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-17 Thread Chris Wilson
On Wed, Jun 17, 2015 at 04:39:32PM -0300, Paulo Zanoni wrote: > 2015-06-17 4:52 GMT-03:00 Chris Wilson : > > These busy bits are locked higher up. In fact I want to migrate that > > lock to a spinlock, which has implications here. I didn't see anything > > that mandated using a mutex for fbc, right

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-17 Thread Paulo Zanoni
2015-06-17 4:52 GMT-03:00 Chris Wilson : > On Tue, Jan 02, 2001 at 04:58:58AM -0200, Paulo Zanoni wrote: >> void intel_fbc_invalidate(struct drm_i915_private *dev_priv, >> unsigned int frontbuffer_bits, >> enum fb_op_origin origin) >> @@ -691,6 +725,

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-17 Thread Daniel Vetter
On Tue, Jan 02, 2001 at 04:58:58AM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Make sure we're not gonna have weird races in really weird cases where > a lot of different CRTCs are doing rendering and modesets at the same > time. > > v2: > - Rebase (6 months later) > - Also lock debugf

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-17 Thread Chris Wilson
On Tue, Jan 02, 2001 at 04:58:58AM -0200, Paulo Zanoni wrote: > void intel_fbc_invalidate(struct drm_i915_private *dev_priv, > unsigned int frontbuffer_bits, > enum fb_op_origin origin) > @@ -691,6 +725,8 @@ void intel_fbc_invalidate(struct drm_i915_

Re: [Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-17 Thread Chris Wilson
On Tue, Jan 02, 2001 at 04:58:58AM -0200, Paulo Zanoni wrote: > @@ -1619,7 +1621,11 @@ static int i915_fbc_fc_get(void *data, u64 *val) > return -ENODEV; > > drm_modeset_lock_all(dev); > + mutex_lock(&dev_priv->fbc.lock); > + > *val = dev_priv->fbc.false_color; > + >

[Intel-gfx] [PATCH 2/3] drm/i915: add the FBC mutex

2015-06-16 Thread Paulo Zanoni
From: Paulo Zanoni Make sure we're not gonna have weird races in really weird cases where a lot of different CRTCs are doing rendering and modesets at the same time. v2: - Rebase (6 months later) - Also lock debugfs and stolen. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_debug