Re: [Intel-gfx] [PATCH 2/3] drm/i915: Rename HDMI register field definitions

2011-10-17 Thread Paulo Zanoni
2011/10/14 Chris Wilson : > I'm a little more dubious over the value of this patch. The extra > information is nice, but the patch doesn't impact much upon the > readibility of the code. It seems like this should have the potential to > clarify quite a bit of the logic and make it more consistent,

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Rename HDMI register field definitions

2011-10-14 Thread Chris Wilson
On Fri, 14 Oct 2011 18:17:09 -0300, przan...@gmail.com wrote: > From: Paulo Zanoni > > Also making the differences between HDMI{B,C,D} and SDVO registers for > non-PCH, IBX and CPT more explicit. > > Signed-off-by: Paulo Zanoni I'm a little more dubious over the value of this patch. The extra

[Intel-gfx] [PATCH 2/3] drm/i915: Rename HDMI register field definitions

2011-10-14 Thread przanoni
From: Paulo Zanoni Also making the differences between HDMI{B,C,D} and SDVO registers for non-PCH, IBX and CPT more explicit. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_reg.h | 49 -- drivers/gpu/drm/i915/intel_display.c | 16 ++-