Re: [Intel-gfx] [PATCH 2/3] drm/i915: Hold a wakeref for probing the ring registers

2017-05-31 Thread Mika Kuoppala
Chris Wilson writes: > Allow intel_engine_is_idle() to be called outside of the GT wakeref by > acquiring the device runtime pm for ourselves. This allows the function > to act as check after we assume the engine is idle and we release the GT > wakeref held whilst we have requests. > > [ 2613.401

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Hold a wakeref for probing the ring registers

2017-05-30 Thread Tvrtko Ursulin
On 30/05/2017 13:50, Chris Wilson wrote: On Tue, May 30, 2017 at 01:37:23PM +0100, Tvrtko Ursulin wrote: On 30/05/2017 13:13, Chris Wilson wrote: Allow intel_engine_is_idle() to be called outside of the GT wakeref by acquiring the device runtime pm for ourselves. This allows the function to a

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Hold a wakeref for probing the ring registers

2017-05-30 Thread Chris Wilson
On Tue, May 30, 2017 at 01:37:23PM +0100, Tvrtko Ursulin wrote: > > On 30/05/2017 13:13, Chris Wilson wrote: > >Allow intel_engine_is_idle() to be called outside of the GT wakeref by > >acquiring the device runtime pm for ourselves. This allows the function > >to act as check after we assume the e

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Hold a wakeref for probing the ring registers

2017-05-30 Thread Tvrtko Ursulin
On 30/05/2017 13:13, Chris Wilson wrote: Allow intel_engine_is_idle() to be called outside of the GT wakeref by acquiring the device runtime pm for ourselves. This allows the function to act as check after we assume the engine is idle and we release the GT wakeref held whilst we have requests.

[Intel-gfx] [PATCH 2/3] drm/i915: Hold a wakeref for probing the ring registers

2017-05-30 Thread Chris Wilson
Allow intel_engine_is_idle() to be called outside of the GT wakeref by acquiring the device runtime pm for ourselves. This allows the function to act as check after we assume the engine is idle and we release the GT wakeref held whilst we have requests. [ 2613.401647] RPM wakelock ref not held dur