Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bring UP Power Wells before disabling RC6.

2013-12-10 Thread S, Deepak
Vetter; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bring UP Power Wells before disabling RC6. On Mon, Dec 09, 2013 at 02:14:03PM +, S, Deepak wrote: > >What precisely does this fix? All our register access is already wrapped in > >get/put calls,

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bring UP Power Wells before disabling RC6.

2013-12-09 Thread Daniel Vetter
nce our own code surely doesn't need it. -Daniel > > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Monday, December 9, 2013 1:31 PM > To: S, Deepak > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gf

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bring UP Power Wells before disabling RC6.

2013-12-09 Thread S, Deepak
nd/Resume path. -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, December 9, 2013 1:31 PM To: S, Deepak Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bring UP Power Wells before disabling RC6.

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bring UP Power Wells before disabling RC6.

2013-12-09 Thread Daniel Vetter
On Sun, Dec 08, 2013 at 01:52:46PM +0530, deepa...@intel.com wrote: > From: Deepak S > > Instead of waiting for HW to bringup the wells, We force the wells up > before disabling RC6. This is to avoid any register access when wells > are down. > > Signed-off-by: Deepak S > --- > drivers/gpu/drm

[Intel-gfx] [PATCH 2/3] drm/i915: Bring UP Power Wells before disabling RC6.

2013-12-08 Thread deepak . s
From: Deepak S Instead of waiting for HW to bringup the wells, We force the wells up before disabling RC6. This is to avoid any register access when wells are down. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/intel_pm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu