Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-07-04 11:58:38) >> Chris Wilson writes: >> >> > Quoting Matthew Auld (2019-07-04 11:28:18) >> >> On 03/07/2019 18:19, Chris Wilson wrote: >> >> > If we hit an error while allocating the page tables, we have to unwind >> >> > the incomplete upda

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-04 11:58:38) > Chris Wilson writes: > > > Quoting Matthew Auld (2019-07-04 11:28:18) > >> On 03/07/2019 18:19, Chris Wilson wrote: > >> > If we hit an error while allocating the page tables, we have to unwind > >> > the incomplete updates, and wish to free the unuse

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Matthew Auld (2019-07-04 11:28:18) >> On 03/07/2019 18:19, Chris Wilson wrote: >> > If we hit an error while allocating the page tables, we have to unwind >> > the incomplete updates, and wish to free the unused pd. However, we are >> > not allowed to be hoding the

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Chris Wilson
Quoting Matthew Auld (2019-07-04 11:28:18) > On 03/07/2019 18:19, Chris Wilson wrote: > > If we hit an error while allocating the page tables, we have to unwind > > the incomplete updates, and wish to free the unused pd. However, we are > > not allowed to be hoding the spinlock at that point, and s

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Matthew Auld
On 03/07/2019 18:19, Chris Wilson wrote: If we hit an error while allocating the page tables, we have to unwind the incomplete updates, and wish to free the unused pd. However, we are not allowed to be hoding the spinlock at that point, and so must use the holding later free to defer it until

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > If we hit an error while allocating the page tables, we have to unwind > the incomplete updates, and wish to free the unused pd. However, we are > not allowed to be hoding the spinlock at that point, and so must use the > later free to defer it until after we drop the lock.

[Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-03 Thread Chris Wilson
If we hit an error while allocating the page tables, we have to unwind the incomplete updates, and wish to free the unused pd. However, we are not allowed to be hoding the spinlock at that point, and so must use the later free to defer it until after we drop the lock. <3> [414.363795] BUG: sleepin