Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Dhinakaran Pandiyan
On Tue, 2018-04-24 at 13:55 -0700, Rodrigo Vivi wrote: > On Mon, Apr 23, 2018 at 07:56:58PM -0700, Dhinakaran Pandiyan wrote: > > Sink crc is calculated by the sink for static frames irrespective of > > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only use > > case for sink crc

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 07:56:58PM -0700, Dhinakaran Pandiyan wrote: > Sink crc is calculated by the sink for static frames irrespective of > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only use > case for sink crc, we don't really need the sink_crc_{start, stop} code. > > The s

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Dhinakaran Pandiyan
On Tue, 2018-04-24 at 16:26 +0300, Mika Kahola wrote: > On Mon, 2018-04-23 at 19:56 -0700, Dhinakaran Pandiyan wrote: > > Sink crc is calculated by the sink for static frames irrespective of > > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only > > use > > case for sink crc, we do

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Mika Kahola
On Mon, 2018-04-23 at 19:56 -0700, Dhinakaran Pandiyan wrote: > Sink crc is calculated by the sink for static frames irrespective of > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only > use > case for sink crc, we don't really need the sink_crc_{start, stop} > code. > > The seco

[Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-23 Thread Dhinakaran Pandiyan
Sink crc is calculated by the sink for static frames irrespective of what the driver sets in TEST_SINK_START dpcd. Since PSR is the only use case for sink crc, we don't really need the sink_crc_{start, stop} code. The second problem with the current implementation is vblank waits. Enabling vblank