Re: [Intel-gfx] [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-23 Thread Ville Syrjälä
On Fri, Mar 23, 2018 at 03:58:06PM +0200, Ville Syrjälä wrote: > On Fri, Mar 23, 2018 at 02:37:23PM +0100, Noralf Trønnes wrote: > > > > Den 23.03.2018 12.31, skrev Ville Syrjälä: > > > On Fri, Mar 23, 2018 at 12:43:58AM +0100, Noralf Trønnes wrote: > > >> > > >> Den 22.03.2018 21.27, skrev Ville

Re: [Intel-gfx] [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-23 Thread Ville Syrjälä
On Fri, Mar 23, 2018 at 02:37:23PM +0100, Noralf Trønnes wrote: > > Den 23.03.2018 12.31, skrev Ville Syrjälä: > > On Fri, Mar 23, 2018 at 12:43:58AM +0100, Noralf Trønnes wrote: > >> > >> Den 22.03.2018 21.27, skrev Ville Syrjala: > >>> From: Ville Syrjälä > >>> > >>> mipi_dbi_enable_flush() wan

Re: [Intel-gfx] [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-23 Thread Noralf Trønnes
Den 23.03.2018 12.31, skrev Ville Syrjälä: On Fri, Mar 23, 2018 at 12:43:58AM +0100, Noralf Trønnes wrote: Den 22.03.2018 21.27, skrev Ville Syrjala: From: Ville Syrjälä mipi_dbi_enable_flush() wants to call the fb->dirty() hook from the bowels of the .atomic_enable() hook. That prevents us

Re: [Intel-gfx] [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-23 Thread Ville Syrjälä
On Fri, Mar 23, 2018 at 12:43:58AM +0100, Noralf Trønnes wrote: > > > Den 22.03.2018 21.27, skrev Ville Syrjala: > > From: Ville Syrjälä > > > > mipi_dbi_enable_flush() wants to call the fb->dirty() hook from the > > bowels of the .atomic_enable() hook. That prevents us from taking the > > plane

Re: [Intel-gfx] [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-22 Thread Noralf Trønnes
Den 22.03.2018 21.27, skrev Ville Syrjala: From: Ville Syrjälä mipi_dbi_enable_flush() wants to call the fb->dirty() hook from the bowels of the .atomic_enable() hook. That prevents us from taking the plane mutex in fb->dirty() unless we also plumb down the acquire context. Instead it seems

[Intel-gfx] [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä mipi_dbi_enable_flush() wants to call the fb->dirty() hook from the bowels of the .atomic_enable() hook. That prevents us from taking the plane mutex in fb->dirty() unless we also plumb down the acquire context. Instead it seems simpler to split the fb->dirty() into a tinydrm