Re: [Intel-gfx] [PATCH 2/2] drm/i915: no interruptible locking for dma_buf->map

2013-08-07 Thread Daniel Vetter
On Wed, Aug 7, 2013 at 12:30 PM, Chris Wilson wrote: > On Wed, Aug 07, 2013 at 12:09:33PM +0200, Daniel Vetter wrote: >> It's unclear whether ->map is allowed to fail with -EINTR, but >> looking at current callers it's pretty clear that they don't >> expect this to happen. So use a blocking mutex_

Re: [Intel-gfx] [PATCH 2/2] drm/i915: no interruptible locking for dma_buf->map

2013-08-07 Thread Chris Wilson
On Wed, Aug 07, 2013 at 12:09:33PM +0200, Daniel Vetter wrote: > It's unclear whether ->map is allowed to fail with -EINTR, but > looking at current callers it's pretty clear that they don't > expect this to happen. So use a blocking mutex_lock call. Since > we don't wait for the gpu in our ->map c

[Intel-gfx] [PATCH 2/2] drm/i915: no interruptible locking for dma_buf->map

2013-08-07 Thread Daniel Vetter
It's unclear whether ->map is allowed to fail with -EINTR, but looking at current callers it's pretty clear that they don't expect this to happen. So use a blocking mutex_lock call. Since we don't wait for the gpu in our ->map callback the lack of the gpu hang checks doesn't matter. Furthermore th