Re: [Intel-gfx] [PATCH 2/2] drm/i915: debugs: Add support for probing DP sink CRC.

2014-01-16 Thread Damien Lespiau
On Thu, Jan 16, 2014 at 05:55:06PM +, Damien Lespiau wrote: > > + /* Wait 2 vblanks to be sure we will have the correct CRC value */ > > + intel_wait_for_vblank(dev, intel_crtc->pipe); > > + intel_wait_for_vblank(dev, intel_crtc->pipe); > > I think there's a better way to do this. There'

Re: [Intel-gfx] [PATCH 2/2] drm/i915: debugs: Add support for probing DP sink CRC.

2014-01-16 Thread Damien Lespiau
On Tue, Jan 14, 2014 at 04:21:50PM -0200, Rodrigo Vivi wrote: > This debugfs interface will allow intel-gpu-tools test case > to verify if screen has been updated properly on cases like PSR. > > v2: Accepted all Daniel's suggestions: > * grab modeset lock > * loop over connector and check

[Intel-gfx] [PATCH 2/2] drm/i915: debugs: Add support for probing DP sink CRC.

2014-01-14 Thread Rodrigo Vivi
This debugfs interface will allow intel-gpu-tools test case to verify if screen has been updated properly on cases like PSR. v2: Accepted all Daniel's suggestions: * grab modeset lock * loop over connector and check DPMS on * return errors * use _eDP1 suffix for easy future extensi