On Mon, 26 Nov 2012 20:09:00 +0200
Ville Syrjälä wrote:
> On Mon, Nov 26, 2012 at 05:46:48PM +, Chris Wilson wrote:
> > On Mon, 26 Nov 2012 19:40:16 +0200, Ville Syrjälä
> > wrote:
> > > On Mon, Nov 26, 2012 at 04:25:47PM +, Chris Wilson wrote:
> > > > On Mon, 26 Nov 2012 14:48:19 +0200
On Mon, Nov 26, 2012 at 05:46:48PM +, Chris Wilson wrote:
> On Mon, 26 Nov 2012 19:40:16 +0200, Ville Syrjälä
> wrote:
> > On Mon, Nov 26, 2012 at 04:25:47PM +, Chris Wilson wrote:
> > > On Mon, 26 Nov 2012 14:48:19 +0200, ville.syrj...@linux.intel.com wrote:
> > > > From: Ville Syrjälä
On Mon, 26 Nov 2012 19:40:16 +0200, Ville Syrjälä
wrote:
> On Mon, Nov 26, 2012 at 04:25:47PM +, Chris Wilson wrote:
> > On Mon, 26 Nov 2012 14:48:19 +0200, ville.syrj...@linux.intel.com wrote:
> > > From: Ville Syrjälä
> > >
> > > Ringbuffer tail pointer must be qword aligned. Warn if
On Mon, Nov 26, 2012 at 04:25:47PM +, Chris Wilson wrote:
> On Mon, 26 Nov 2012 14:48:19 +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Ringbuffer tail pointer must be qword aligned. Warn if someone
> > makes a mistake and forgets to pad the ring when the commands
On Mon, 26 Nov 2012 14:48:19 +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Ringbuffer tail pointer must be qword aligned. Warn if someone
> makes a mistake and forgets to pad the ring when the commands
> inserted into the ring don't align to qword naturally.
The asserti
On Mon, Nov 26, 2012 at 1:48 PM, wrote:
> + /* tail must be qword aligned */
> + WARN_ON(ring->tail & 7);
Minor bikeshed: Can you move the comment into the WARN argument so
that if someone forgets to correctly pad stuff, dmesg will directly
tell him wants wrong, instead of being forc
From: Ville Syrjälä
Ringbuffer tail pointer must be qword aligned. Warn if someone
makes a mistake and forgets to pad the ring when the commands
inserted into the ring don't align to qword naturally.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ringbuffer.c |2 ++
1 files ch
