Re: [Intel-gfx] [PATCH 2/2] drm/i915: Update sprite watermarks outside vblank evasion

2015-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2015 at 07:29:58AM -0700, Matt Roper wrote: > On Tue, Jun 23, 2015 at 09:34:50AM +0200, Daniel Vetter wrote: > > On Mon, Jun 22, 2015 at 06:30:33PM -0700, Matt Roper wrote: > > > We never removed the sprite watermark updates from our low-level > > > foo_update_plane() functions; sin

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Update sprite watermarks outside vblank evasion

2015-06-23 Thread Matt Roper
On Tue, Jun 23, 2015 at 09:34:50AM +0200, Daniel Vetter wrote: > On Mon, Jun 22, 2015 at 06:30:33PM -0700, Matt Roper wrote: > > We never removed the sprite watermark updates from our low-level > > foo_update_plane() functions; since our hardware updates happen under > > vblank evasion, we're not s

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Update sprite watermarks outside vblank evasion

2015-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2015 at 06:30:33PM -0700, Matt Roper wrote: > We never removed the sprite watermark updates from our low-level > foo_update_plane() functions; since our hardware updates happen under > vblank evasion, we're not supposed to be calling potentially sleeping > functions there (since int

[Intel-gfx] [PATCH 2/2] drm/i915: Update sprite watermarks outside vblank evasion

2015-06-22 Thread Matt Roper
We never removed the sprite watermark updates from our low-level foo_update_plane() functions; since our hardware updates happen under vblank evasion, we're not supposed to be calling potentially sleeping functions there (since interrupts are disabled). We do already have a mechanism that's suppos