Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-10 Thread Ville Syrjälä
On Wed, Apr 10, 2019 at 07:13:48PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2019-04-10 18:59:52) > > On Mon, Apr 08, 2019 at 06:05:06PM +0100, Chris Wilson wrote: > > > Quoting Ville Syrjälä (2019-04-08 17:06:01) > > > > On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-10 Thread Chris Wilson
Quoting Ville Syrjälä (2019-04-10 18:59:52) > On Mon, Apr 08, 2019 at 06:05:06PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjälä (2019-04-08 17:06:01) > > > On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > > > > Quoting Ville Syrjala (2019-04-08 16:27:02) > > > > > - /* >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-10 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 06:05:06PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2019-04-08 17:06:01) > > On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > > > Quoting Ville Syrjala (2019-04-08 16:27:02) > > > > - /* > > > > -* Adjust the original formula to delay

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Chris Wilson
Quoting Ville Syrjälä (2019-04-08 17:06:01) > On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2019-04-08 16:27:02) > > > - /* > > > -* Adjust the original formula to delay the division by 2^22 in > > > order to > > > -* minimize possib

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Chris Wilson
Quoting Ville Syrjälä (2019-04-08 17:06:01) > On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2019-04-08 16:27:02) > > > - /* > > > -* Adjust the original formula to delay the division by 2^22 in > > > order to > > > -* minimize possib

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2019-04-08 16:27:02) > > - /* > > -* Adjust the original formula to delay the division by 2^22 in > > order to > > -* minimize possible rounding errors. > > -*/ > > - tmp = (u

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Chris Wilson
Quoting Ville Syrjala (2019-04-08 16:27:02) > - /* > -* Adjust the original formula to delay the division by 2^22 in order > to > -* minimize possible rounding errors. > -*/ > - tmp = (u64)m1 * m2_int * ref_clock + > - (((u64)m1 * m2_frac * ref_clock

[Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Ville Syrjala
From: Ville Syrjälä Write some icl pll calculations in a more straightforward way. We have just enough bits for the full divisor. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ddi.c | 15 --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +- 2 files changed, 5 inser