Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorganize .disable hooks for pre-DDI DP

2017-09-20 Thread Ville Syrjälä
On Mon, Sep 18, 2017 at 01:45:50PM -0700, Rodrigo Vivi wrote: > On Mon, Sep 18, 2017 at 05:31:28PM +, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Most of our DP encoder hooks are split into per-platform variants. > > .disable() an exception, and thus it's a bit messy. Let's split it

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorganize .disable hooks for pre-DDI DP

2017-09-18 Thread Rodrigo Vivi
On Mon, Sep 18, 2017 at 05:31:28PM +, Ville Syrjala wrote: > From: Ville Syrjälä > > Most of our DP encoder hooks are split into per-platform variants. > .disable() an exception, and thus it's a bit messy. Let's split it > up as well. We'll leave the common parts in a helper called by > each

[Intel-gfx] [PATCH 2/2] drm/i915: Reorganize .disable hooks for pre-DDI DP

2017-09-18 Thread Ville Syrjala
From: Ville Syrjälä Most of our DP encoder hooks are split into per-platform variants. .disable() an exception, and thus it's a bit messy. Let's split it up as well. We'll leave the common parts in a helper called by each platform specific hook. There is a subtle change on VLV/CHV where we now d