Re: [Intel-gfx] [PATCH 2/2] drm/i915: Protect engine request list with spinlock

2015-02-24 Thread Mika Kuoppala
Chris Wilson writes: > On Tue, Feb 24, 2015 at 11:39:08AM +0100, Daniel Vetter wrote: >> On Tue, Feb 24, 2015 at 08:31:18AM +, Chris Wilson wrote: >> > On Tue, Feb 24, 2015 at 12:58:19AM +0100, Daniel Vetter wrote: >> > > On Thu, Feb 19, 2015 at 04:41:12PM +, Chris Wilson wrote: >> > > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Protect engine request list with spinlock

2015-02-24 Thread Chris Wilson
On Tue, Feb 24, 2015 at 11:39:08AM +0100, Daniel Vetter wrote: > On Tue, Feb 24, 2015 at 08:31:18AM +, Chris Wilson wrote: > > On Tue, Feb 24, 2015 at 12:58:19AM +0100, Daniel Vetter wrote: > > > On Thu, Feb 19, 2015 at 04:41:12PM +, Chris Wilson wrote: > > > > On Thu, Feb 19, 2015 at 06:18

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Protect engine request list with spinlock

2015-02-24 Thread Chris Wilson
On Tue, Feb 24, 2015 at 12:58:19AM +0100, Daniel Vetter wrote: > On Thu, Feb 19, 2015 at 04:41:12PM +, Chris Wilson wrote: > > On Thu, Feb 19, 2015 at 06:18:55PM +0200, Mika Kuoppala wrote: > > > There are multiple players interested in the ring->request_list > > > state. Request submission can

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Protect engine request list with spinlock

2015-02-19 Thread Chris Wilson
On Thu, Feb 19, 2015 at 06:18:55PM +0200, Mika Kuoppala wrote: > There are multiple players interested in the ring->request_list > state. Request submission can happen in kernel or user context, > idle worker is going through request list to free items. And then there > is hangcheck worker which tr

[Intel-gfx] [PATCH 2/2] drm/i915: Protect engine request list with spinlock

2015-02-19 Thread Mika Kuoppala
There are multiple players interested in the ring->request_list state. Request submission can happen in kernel or user context, idle worker is going through request list to free items. And then there is hangcheck worker which tries to figure out if particular ring is healthy by peeking at the reque