Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-04-29 Thread Chris Wilson
On Tue, Apr 29, 2014 at 10:33:00AM +0200, Daniel Vetter wrote: > On Tue, Apr 29, 2014 at 3:10 AM, Ben Widawsky wrote: > > On Sat, Jan 25, 2014 at 08:10:06PM +0100, Daniel Vetter wrote: > >> On Fri, Jan 24, 2014 at 12:13:44PM -0800, Ben Widawsky wrote: > >> > ping > >> > >> Merged the first patch t

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-04-29 Thread Daniel Vetter
On Tue, Apr 29, 2014 at 3:10 AM, Ben Widawsky wrote: > On Sat, Jan 25, 2014 at 08:10:06PM +0100, Daniel Vetter wrote: >> On Fri, Jan 24, 2014 at 12:13:44PM -0800, Ben Widawsky wrote: >> > ping >> >> Merged the first patch to topic/ppgtt, but punted on the 2nd - I think >> with Mika's improvement t

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-04-28 Thread Ben Widawsky
On Sat, Jan 25, 2014 at 08:10:06PM +0100, Daniel Vetter wrote: > On Fri, Jan 24, 2014 at 12:13:44PM -0800, Ben Widawsky wrote: > > ping > > Merged the first patch to topic/ppgtt, but punted on the 2nd - I think > with Mika's improvement to the guilty batch detection we should be able to > fix this

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-01-25 Thread Daniel Vetter
On Fri, Jan 24, 2014 at 12:13:44PM -0800, Ben Widawsky wrote: > ping Merged the first patch to topic/ppgtt, but punted on the 2nd - I think with Mika's improvement to the guilty batch detection we should be able to fix this better. Or what's the consensus here? Aside: I didn't spot your r-b burri

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-01-24 Thread Ben Widawsky
ping On Fri, Jan 10, 2014 at 08:08:26PM +, Chris Wilson wrote: > On Fri, Jan 10, 2014 at 11:59:10AM -0800, Ben Widawsky wrote: > > I will gladly re-review if you make any of my suggested changes. > > Hmm, I had already done the capture_vma one since that is required to > display the right add

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-01-10 Thread Chris Wilson
On Fri, Jan 10, 2014 at 11:59:10AM -0800, Ben Widawsky wrote: > I will gladly re-review if you make any of my suggested changes. Hmm, I had already done the capture_vma one since that is required to display the right addresses in the error state. The output is like: vm[0] Active [0]: Pinned

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-01-10 Thread Ben Widawsky
On Thu, Jan 09, 2014 at 10:57:23PM +, Chris Wilson wrote: > The current error state harks back to the era of just a single VM. For > full-ppgtt, we capture every bo on every VM. It behoves us to then print > every bo for every VM, which we currently fail to do and so miss vital > information in

[Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-01-09 Thread Chris Wilson
The current error state harks back to the era of just a single VM. For full-ppgtt, we capture every bo on every VM. It behoves us to then print every bo for every VM, which we currently fail to do and so miss vital information in the error state. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i