Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file

2014-01-15 Thread Ben Widawsky
On Wed, Jan 15, 2014 at 01:22:00AM +, Damien Lespiau wrote: > On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#if 0 > > +#include > > +#include > > +#endif > > Could remove that #if > Thanks, I lef

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 2:22 AM, Damien Lespiau wrote: > On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote: >> +#include >> +#include >> +#include >> +#include >> +#include >> +#if 0 >> +#include >> +#include >> +#endif > > Could remove that #if > > Last time I remember we talked

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file

2014-01-14 Thread Damien Lespiau
On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote: > +#include > +#include > +#include > +#include > +#include > +#if 0 > +#include > +#include > +#endif Could remove that #if Last time I remember we talked about a intel_display_test.c where we could shove more stuff (Rodrigo's

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file

2014-01-14 Thread Daniel Vetter
On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote: > At almost 800 lines of code, with almost a function per platform, this > code was cluttering up the existing debugfs file, which has > historically had fairly small functions. > > Patch should have no functional changes. > > Signed-o

[Intel-gfx] [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file

2014-01-14 Thread Ben Widawsky
At almost 800 lines of code, with almost a function per platform, this code was cluttering up the existing debugfs file, which has historically had fairly small functions. Patch should have no functional changes. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/Makefile | 2 +- driv