Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj() (v2)

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 10:29:09AM +0100, Chris Wilson wrote: > On Tue, Jul 08, 2014 at 07:50:07AM -0700, Matt Roper wrote: > > This should hopefully simplify the display code slightly and also > > solves at least one mistake in intel_pipe_set_base() where > > to_intel_framebuffer(fb)->obj is refer

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj() (v2)

2014-07-09 Thread Chris Wilson
On Tue, Jul 08, 2014 at 07:50:07AM -0700, Matt Roper wrote: > This should hopefully simplify the display code slightly and also > solves at least one mistake in intel_pipe_set_base() where > to_intel_framebuffer(fb)->obj is referenced during local variable > initialization, before 'if (!fb)' gets c

[Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj() (v2)

2014-07-08 Thread Matt Roper
This should hopefully simplify the display code slightly and also solves at least one mistake in intel_pipe_set_base() where to_intel_framebuffer(fb)->obj is referenced during local variable initialization, before 'if (!fb)' gets checked. Potential uses of this macro were identified via the follow

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 11:06:49AM +0100, Chris Wilson wrote: > On Tue, Jul 08, 2014 at 11:51:18AM +0200, Daniel Vetter wrote: > > On Tue, Jul 08, 2014 at 07:47:13AM +0100, Chris Wilson wrote: > > > On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > > > > This should hopefully simplify t

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-08 Thread Chris Wilson
On Tue, Jul 08, 2014 at 11:51:18AM +0200, Daniel Vetter wrote: > On Tue, Jul 08, 2014 at 07:47:13AM +0100, Chris Wilson wrote: > > On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > > > This should hopefully simplify the display code slightly and also > > > solves at least one mistake in

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 07:47:13AM +0100, Chris Wilson wrote: > On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > > This should hopefully simplify the display code slightly and also > > solves at least one mistake in intel_pipe_set_base() where > > to_intel_framebuffer(fb)->obj is refer

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-07 Thread Chris Wilson
On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > This should hopefully simplify the display code slightly and also > solves at least one mistake in intel_pipe_set_base() where > to_intel_framebuffer(fb)->obj is referenced during local variable > initialization, before 'if (!fb)' gets c

[Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-07 Thread Matt Roper
This should hopefully simplify the display code slightly and also solves at least one mistake in intel_pipe_set_base() where to_intel_framebuffer(fb)->obj is referenced during local variable initialization, before 'if (!fb)' gets checked. Potential uses of this macro were identified via the follow