Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-30 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 01:57:16PM +0200, Ville Syrjälä wrote: > On Wed, Jan 28, 2015 at 10:29:06AM +, Chris Wilson wrote: > > On Tue, Jan 27, 2015 at 04:36:16PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Replace the valleyview_set_rps() and gen6_se

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-29 Thread Ville Syrjälä
On Wed, Jan 28, 2015 at 10:29:06AM +, Chris Wilson wrote: > On Tue, Jan 27, 2015 at 04:36:16PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Replace the valleyview_set_rps() and gen6_set_rps() calls with > > intel_set_rps() which itself does the IS_VALLEYVIEW() c

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-28 Thread Chris Wilson
On Tue, Jan 27, 2015 at 04:36:16PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Replace the valleyview_set_rps() and gen6_set_rps() calls with > intel_set_rps() which itself does the IS_VALLEYVIEW() check. The > code becomes simpler since the callers don't have to do this

[Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-27 Thread ville . syrjala
From: Ville Syrjälä Replace the valleyview_set_rps() and gen6_set_rps() calls with intel_set_rps() which itself does the IS_VALLEYVIEW() check. The code becomes simpler since the callers don't have to do this check themselves. Most of the change was performe with the following semantic patch: @@