Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks

2016-05-09 Thread Ville Syrjälä
On Wed, May 04, 2016 at 02:30:28PM +0200, Maarten Lankhorst wrote: > Op 29-04-16 om 16:31 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > When the crtc is enabled but !active, we should still compute the > > watermarks as if the planes were visible. That would make it more >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks

2016-05-04 Thread Maarten Lankhorst
Op 29-04-16 om 16:31 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > When the crtc is enabled but !active, we should still compute the > watermarks as if the planes were visible. That would make it more > likely that the we can later transition to active without errors. > > Add a

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks

2016-05-02 Thread Daniel Vetter
On Fri, Apr 29, 2016 at 05:31:18PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > When the crtc is enabled but !active, we should still compute the > watermarks as if the planes were visible. That would make it more > likely that the we can later transition to active withou

[Intel-gfx] [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks

2016-04-29 Thread ville . syrjala
From: Ville Syrjälä When the crtc is enabled but !active, we should still compute the watermarks as if the planes were visible. That would make it more likely that the we can later transition to active without errors. Add a FIXME to remind people that we're doing the wrong thing now. We should p