Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-14 Thread Daniel Vetter
On Tue, Apr 14, 2015 at 05:49:40PM +0530, Jindal, Sonika wrote: > > > On 4/14/2015 5:09 AM, Matt Roper wrote: > >On Mon, Apr 13, 2015 at 01:49:22PM +0300, Ville Syrjälä wrote: > >>On Mon, Apr 13, 2015 at 03:53:22PM +0530, Jindal, Sonika wrote: > >>> > >>> > >>>On 4/13/2015 3:40 PM, Ville Syrjälä

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-14 Thread Jindal, Sonika
On 4/14/2015 5:09 AM, Matt Roper wrote: On Mon, Apr 13, 2015 at 01:49:22PM +0300, Ville Syrjälä wrote: On Mon, Apr 13, 2015 at 03:53:22PM +0530, Jindal, Sonika wrote: On 4/13/2015 3:40 PM, Ville Syrjälä wrote: On Mon, Apr 13, 2015 at 09:36:02AM +0530, Jindal, Sonika wrote: On 4/10/2015

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-13 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6170 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-13 Thread Matt Roper
On Mon, Apr 13, 2015 at 01:49:22PM +0300, Ville Syrjälä wrote: > On Mon, Apr 13, 2015 at 03:53:22PM +0530, Jindal, Sonika wrote: > > > > > > On 4/13/2015 3:40 PM, Ville Syrjälä wrote: > > > On Mon, Apr 13, 2015 at 09:36:02AM +0530, Jindal, Sonika wrote: > > >> > > >> > > >> On 4/10/2015 8:14 PM,

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-13 Thread Damien Lespiau
On Mon, Apr 13, 2015 at 03:53:22PM +0530, Jindal, Sonika wrote: > >>I never really got the to understand the need of reversing 90 and 270 :) > >>The last discussion was not concluded, AFAIR. > >>Things look correct to me and work fine with the testcase also. > >>Is there something completely differ

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-13 Thread Ville Syrjälä
On Mon, Apr 13, 2015 at 03:53:22PM +0530, Jindal, Sonika wrote: > > > On 4/13/2015 3:40 PM, Ville Syrjälä wrote: > > On Mon, Apr 13, 2015 at 09:36:02AM +0530, Jindal, Sonika wrote: > >> > >> > >> On 4/10/2015 8:14 PM, Ville Syrjälä wrote: > >>> On Fri, Apr 10, 2015 at 04:17:17PM +0200, Daniel Vet

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-13 Thread Jindal, Sonika
On 4/13/2015 3:40 PM, Ville Syrjälä wrote: On Mon, Apr 13, 2015 at 09:36:02AM +0530, Jindal, Sonika wrote: On 4/10/2015 8:14 PM, Ville Syrjälä wrote: On Fri, Apr 10, 2015 at 04:17:17PM +0200, Daniel Vetter wrote: On Fri, Apr 10, 2015 at 02:37:29PM +0530, Sonika Jindal wrote: v2: Moving cr

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-13 Thread Ville Syrjälä
On Mon, Apr 13, 2015 at 09:36:02AM +0530, Jindal, Sonika wrote: > > > On 4/10/2015 8:14 PM, Ville Syrjälä wrote: > > On Fri, Apr 10, 2015 at 04:17:17PM +0200, Daniel Vetter wrote: > >> On Fri, Apr 10, 2015 at 02:37:29PM +0530, Sonika Jindal wrote: > >>> v2: Moving creation of property in a functi

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-12 Thread Jindal, Sonika
On 4/10/2015 8:14 PM, Ville Syrjälä wrote: On Fri, Apr 10, 2015 at 04:17:17PM +0200, Daniel Vetter wrote: On Fri, Apr 10, 2015 at 02:37:29PM +0530, Sonika Jindal wrote: v2: Moving creation of property in a function, checking for 90/270 rotation simultaneously (Chris) Letting primary plane to

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-12 Thread Jindal, Sonika
On 4/10/2015 7:47 PM, Daniel Vetter wrote: On Fri, Apr 10, 2015 at 02:37:29PM +0530, Sonika Jindal wrote: v2: Moving creation of property in a function, checking for 90/270 rotation simultaneously (Chris) Letting primary plane to be positioned v3: Adding if/else for 90/270 and rest params prog

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-07 Thread Jindal, Sonika
On 4/7/2015 1:43 PM, Daniel Vetter wrote: On Thu, Apr 02, 2015 at 08:59:33AM -0700, Matt Roper wrote: On Thu, Apr 02, 2015 at 10:24:02AM +0530, Jindal, Sonika wrote: I am not sure how it will help. drm_plane_check_pixel_format should be used to check the pixel format of the fb which we should

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-07 Thread Daniel Vetter
On Thu, Apr 02, 2015 at 08:59:33AM -0700, Matt Roper wrote: > On Thu, Apr 02, 2015 at 10:24:02AM +0530, Jindal, Sonika wrote: > > I am not sure how it will help. drm_plane_check_pixel_format should > > be used to check the pixel format of the fb which we should be doing > > in some -check functions

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-06 Thread Jindal, Sonika
On 4/2/2015 9:29 PM, Matt Roper wrote: On Thu, Apr 02, 2015 at 10:24:02AM +0530, Jindal, Sonika wrote: On 4/1/2015 11:52 PM, Matt Roper wrote: On Mon, Mar 30, 2015 at 02:04:57PM +0530, Sonika Jindal wrote: v2: Moving creation of property in a function, checking for 90/270 rotation simultan

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-02 Thread Matt Roper
On Thu, Apr 02, 2015 at 10:24:02AM +0530, Jindal, Sonika wrote: > > > On 4/1/2015 11:52 PM, Matt Roper wrote: > >On Mon, Mar 30, 2015 at 02:04:57PM +0530, Sonika Jindal wrote: > >>v2: Moving creation of property in a function, checking for 90/270 > >>rotation simultaneously (Chris) > >>Letting pr

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-02 Thread Tvrtko Ursulin
Hi, On 04/02/2015 05:54 AM, Jindal, Sonika wrote: diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f0bbc22..86ee0f0 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -2318,6 +2318,28 @@ intel_fill_fb_ggt

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-01 Thread Jindal, Sonika
On 4/1/2015 11:52 PM, Matt Roper wrote: On Mon, Mar 30, 2015 at 02:04:57PM +0530, Sonika Jindal wrote: v2: Moving creation of property in a function, checking for 90/270 rotation simultaneously (Chris) Letting primary plane to be positioned v3: Adding if/else for 90/270 and rest params program

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-04-01 Thread Matt Roper
On Mon, Mar 30, 2015 at 02:04:57PM +0530, Sonika Jindal wrote: > v2: Moving creation of property in a function, checking for 90/270 > rotation simultaneously (Chris) > Letting primary plane to be positioned > v3: Adding if/else for 90/270 and rest params programming, adding check for > pixel_format

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-03-30 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6091 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -4 270/270

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation

2015-03-30 Thread Sonika Jindal
v2: Moving creation of property in a function, checking for 90/270 rotation simultaneously (Chris) Letting primary plane to be positioned v3: Adding if/else for 90/270 and rest params programming, adding check for pixel_format, some cleanup (review comments) v4: Adding right pixel_formats, using sr