Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Adding DDI_E power well domain

2015-08-31 Thread Jani Nikula
On Thu, 13 Aug 2015, Xiong Zhang wrote: > From B spec, DDI_E port belong to PowerWell 2, but > DDI_E share the powerwell_req/staus register bit with > DDI_A which belong to DDI_A_E_POWER_WELL. > > In order to communicate with the connector on DDI-E, both > DDI_A_E_POWER_WELL and POWER_WELL_2 must

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Adding DDI_E power well domain

2015-08-24 Thread Vivi, Rodrigo
On Mon, 2015-08-17 at 01:50 +, Zhang, Xiong Y wrote: > Sorry, but I don't get how this enables power_well_2 as well. I just > see it enabling ddi A/E as the other. > > Maybe Paulo or Imre are the best one to review this. > > On Thu, Aug 13, 2015 at 2:54 AM Xiong Zhang > wrote: > From B

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Adding DDI_E power well domain

2015-08-16 Thread Zhang, Xiong Y
Sorry, but I don't get how this enables power_well_2 as well. I just see it enabling ddi A/E as the other. Maybe Paulo or Imre are the best one to review this. On Thu, Aug 13, 2015 at 2:54 AM Xiong Zhang mailto:xiong.y.zh...@intel.com>> wrote: From B spec, DDI_E port belong to PowerWell 2, but

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Adding DDI_E power well domain

2015-08-14 Thread Rodrigo Vivi
Sorry, but I don't get how this enables power_well_2 as well. I just see it enabling ddi A/E as the other. Maybe Paulo or Imre are the best one to review this. On Thu, Aug 13, 2015 at 2:54 AM Xiong Zhang wrote: > From B spec, DDI_E port belong to PowerWell 2, but > DDI_E share the powerwell_req

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Adding DDI_E power well domain

2015-08-13 Thread Xiong Zhang
From B spec, DDI_E port belong to PowerWell 2, but DDI_E share the powerwell_req/staus register bit with DDI_A which belong to DDI_A_E_POWER_WELL. In order to communicate with the connector on DDI-E, both DDI_A_E_POWER_WELL and POWER_WELL_2 must be enabled. Currently intel_dp_power_get(DDI_E) onl