Re: [Intel-gfx] [PATCH 19/31] drm/i915: fix up pch pll enabling for pixel multipliers

2013-06-12 Thread Daniel Vetter
On Wed, Jun 12, 2013 at 04:12:48PM +0100, Damien Lespiau wrote: > On Wed, Jun 05, 2013 at 01:34:21PM +0200, Daniel Vetter wrote: > > We have a nice comment saying that the pixel multiplier only sticks > > once the vco is on and stable. The only problem is that the enable bit > > wasn't set at all.

Re: [Intel-gfx] [PATCH 19/31] drm/i915: fix up pch pll enabling for pixel multipliers

2013-06-12 Thread Damien Lespiau
On Wed, Jun 05, 2013 at 01:34:21PM +0200, Daniel Vetter wrote: > We have a nice comment saying that the pixel multiplier only sticks > once the vco is on and stable. The only problem is that the enable bit > wasn't set at all. This patch fixes this and so brings the ilk+ pch > pll code in line with

[Intel-gfx] [PATCH 19/31] drm/i915: fix up pch pll enabling for pixel multipliers

2013-06-05 Thread Daniel Vetter
We have a nice comment saying that the pixel multiplier only sticks once the vco is on and stable. The only problem is that the enable bit wasn't set at all. This patch fixes this and so brings the ilk+ pch pll code in line with the i8xx/i9xx pll code. Or at least improves matters a lot. This shou