Re: [Intel-gfx] [PATCH 19/21] drm/i915: Move the get/put irq locking into the caller

2016-06-08 Thread Chris Wilson
On Wed, Jun 08, 2016 at 12:49:14PM +0100, Tvrtko Ursulin wrote: > > On 08/06/16 12:10, Chris Wilson wrote: > >On Wed, Jun 08, 2016 at 11:18:59AM +0100, Tvrtko Ursulin wrote: > >> > >>On 08/06/16 11:01, Chris Wilson wrote: > >>>On Tue, Jun 07, 2016 at 01:46:53PM +0100, Tvrtko Ursulin wrote: >

Re: [Intel-gfx] [PATCH 19/21] drm/i915: Move the get/put irq locking into the caller

2016-06-08 Thread Tvrtko Ursulin
On 08/06/16 12:10, Chris Wilson wrote: On Wed, Jun 08, 2016 at 11:18:59AM +0100, Tvrtko Ursulin wrote: On 08/06/16 11:01, Chris Wilson wrote: On Tue, Jun 07, 2016 at 01:46:53PM +0100, Tvrtko Ursulin wrote: On 03/06/16 17:08, Chris Wilson wrote: With only a single callsite for intel_engine_

Re: [Intel-gfx] [PATCH 19/21] drm/i915: Move the get/put irq locking into the caller

2016-06-08 Thread Chris Wilson
On Wed, Jun 08, 2016 at 11:18:59AM +0100, Tvrtko Ursulin wrote: > > On 08/06/16 11:01, Chris Wilson wrote: > >On Tue, Jun 07, 2016 at 01:46:53PM +0100, Tvrtko Ursulin wrote: > >> > >>On 03/06/16 17:08, Chris Wilson wrote: > >>>With only a single callsite for intel_engine_cs->irq_get and ->irq_put,

Re: [Intel-gfx] [PATCH 19/21] drm/i915: Move the get/put irq locking into the caller

2016-06-08 Thread Tvrtko Ursulin
On 08/06/16 11:01, Chris Wilson wrote: On Tue, Jun 07, 2016 at 01:46:53PM +0100, Tvrtko Ursulin wrote: On 03/06/16 17:08, Chris Wilson wrote: With only a single callsite for intel_engine_cs->irq_get and ->irq_put, we can reduce the code size by moving the common preamble into the caller, and

Re: [Intel-gfx] [PATCH 19/21] drm/i915: Move the get/put irq locking into the caller

2016-06-08 Thread Chris Wilson
On Tue, Jun 07, 2016 at 01:46:53PM +0100, Tvrtko Ursulin wrote: > > On 03/06/16 17:08, Chris Wilson wrote: > >With only a single callsite for intel_engine_cs->irq_get and ->irq_put, > >we can reduce the code size by moving the common preamble into the > >caller, and we can also eliminate the refer

Re: [Intel-gfx] [PATCH 19/21] drm/i915: Move the get/put irq locking into the caller

2016-06-07 Thread Tvrtko Ursulin
On 03/06/16 17:08, Chris Wilson wrote: With only a single callsite for intel_engine_cs->irq_get and ->irq_put, we can reduce the code size by moving the common preamble into the caller, and we can also eliminate the reference counting. For completeness, as we are no longer doing reference count

[Intel-gfx] [PATCH 19/21] drm/i915: Move the get/put irq locking into the caller

2016-06-03 Thread Chris Wilson
With only a single callsite for intel_engine_cs->irq_get and ->irq_put, we can reduce the code size by moving the common preamble into the caller, and we can also eliminate the reference counting. For completeness, as we are no longer doing reference counting on irq, rename the get/put vfunctions