Re: [Intel-gfx] [PATCH 18/18] drm/i915/runtime_pm: Prefer drm_WARN* over WARN*

2020-04-21 Thread Imre Deak
On Tue, Apr 21, 2020 at 11:28:24AM +0300, Jani Nikula wrote: > > Imre, please check the one question inline. > > On Mon, 06 Apr 2020, Pankaj Bharadiya > wrote: > > struct drm_device specific drm_WARN* macros include device information > > in the backtrace, so we know what device the warnings or

Re: [Intel-gfx] [PATCH 18/18] drm/i915/runtime_pm: Prefer drm_WARN* over WARN*

2020-04-21 Thread Jani Nikula
Imre, please check the one question inline. On Mon, 06 Apr 2020, Pankaj Bharadiya wrote: > struct drm_device specific drm_WARN* macros include device information > in the backtrace, so we know what device the warnings originate from. > > Prefer drm_WARN* over WARN*. > > Conversion is done with

[Intel-gfx] [PATCH 18/18] drm/i915/runtime_pm: Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN* over WARN*. Conversion is done with below semantic patch: @@ identifier func, T; @@ func(struct intel_runtime_pm *T,...) { + struct drm_i9