Re: [Intel-gfx] [PATCH 17/40] drm/i915: Priority boost for waiting clients

2018-09-25 Thread Tvrtko Ursulin
On 25/09/2018 10:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-24 12:29:45) On 19/09/2018 20:55, Chris Wilson wrote: +#define I915_PRIORITY_WAIT ((u8)BIT(1)) #define I915_PRIORITY_NEWCLIENT ((u8)BIT(0)) Put a comment here explaining the priority order is reversed in the i

Re: [Intel-gfx] [PATCH 17/40] drm/i915: Priority boost for waiting clients

2018-09-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-24 12:29:45) > > On 19/09/2018 20:55, Chris Wilson wrote: > > +#define I915_PRIORITY_WAIT ((u8)BIT(1)) > > #define I915_PRIORITY_NEWCLIENT ((u8)BIT(0)) > > Put a comment here explaining the priority order is reversed in the > internal range. > > With new

Re: [Intel-gfx] [PATCH 17/40] drm/i915: Priority boost for waiting clients

2018-09-24 Thread Tvrtko Ursulin
On 19/09/2018 20:55, Chris Wilson wrote: Latency is in the eye of the beholder. In the case where a client stops and waits for the gpu, give that request chain a small priority boost (not so that it overtakes higher priority clients, to preserve the external ordering) so that ideally the wait co

[Intel-gfx] [PATCH 17/40] drm/i915: Priority boost for waiting clients

2018-09-19 Thread Chris Wilson
Latency is in the eye of the beholder. In the case where a client stops and waits for the gpu, give that request chain a small priority boost (not so that it overtakes higher priority clients, to preserve the external ordering) so that ideally the wait completes earlier. Testcase: igt/gem_sync/swi