Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-08 Thread Chris Wilson
On Wed, Jun 08, 2016 at 01:44:27PM +0100, Tvrtko Ursulin wrote: > > On 08/06/16 13:34, Chris Wilson wrote: > >On Wed, Jun 08, 2016 at 12:47:28PM +0100, Tvrtko Ursulin wrote: > >> > >>On 08/06/16 12:24, Chris Wilson wrote: > >>>On Wed, Jun 08, 2016 at 11:16:13AM +0100, Tvrtko Ursulin wrote: >

Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-08 Thread Tvrtko Ursulin
On 08/06/16 13:34, Chris Wilson wrote: On Wed, Jun 08, 2016 at 12:47:28PM +0100, Tvrtko Ursulin wrote: On 08/06/16 12:24, Chris Wilson wrote: On Wed, Jun 08, 2016 at 11:16:13AM +0100, Tvrtko Ursulin wrote: On 08/06/16 10:48, Chris Wilson wrote: On Tue, Jun 07, 2016 at 01:04:22PM +0100, Tvr

Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-08 Thread Chris Wilson
On Wed, Jun 08, 2016 at 12:47:28PM +0100, Tvrtko Ursulin wrote: > > On 08/06/16 12:24, Chris Wilson wrote: > >On Wed, Jun 08, 2016 at 11:16:13AM +0100, Tvrtko Ursulin wrote: > >> > >>On 08/06/16 10:48, Chris Wilson wrote: > >>>On Tue, Jun 07, 2016 at 01:04:22PM +0100, Tvrtko Ursulin wrote: > >

Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-08 Thread Tvrtko Ursulin
On 08/06/16 12:24, Chris Wilson wrote: On Wed, Jun 08, 2016 at 11:16:13AM +0100, Tvrtko Ursulin wrote: On 08/06/16 10:48, Chris Wilson wrote: On Tue, Jun 07, 2016 at 01:04:22PM +0100, Tvrtko Ursulin wrote: +static int intel_breadcrumbs_signaler(void *arg) +{ + struct intel_engine_cs *e

Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-08 Thread Chris Wilson
On Wed, Jun 08, 2016 at 11:16:13AM +0100, Tvrtko Ursulin wrote: > > On 08/06/16 10:48, Chris Wilson wrote: > >On Tue, Jun 07, 2016 at 01:04:22PM +0100, Tvrtko Ursulin wrote: > >>>+static int intel_breadcrumbs_signaler(void *arg) > >>>+{ > >>>+ struct intel_engine_cs *engine = arg; > >>>+ struct

Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-08 Thread Tvrtko Ursulin
On 08/06/16 10:48, Chris Wilson wrote: On Tue, Jun 07, 2016 at 01:04:22PM +0100, Tvrtko Ursulin wrote: +static int intel_breadcrumbs_signaler(void *arg) +{ + struct intel_engine_cs *engine = arg; + struct intel_breadcrumbs *b = &engine->breadcrumbs; + struct signal *signal; +

Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-08 Thread Chris Wilson
On Tue, Jun 07, 2016 at 01:04:22PM +0100, Tvrtko Ursulin wrote: > >+static int intel_breadcrumbs_signaler(void *arg) > >+{ > >+struct intel_engine_cs *engine = arg; > >+struct intel_breadcrumbs *b = &engine->breadcrumbs; > >+struct signal *signal; > >+ > >+/* Install ourselves with

Re: [Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-07 Thread Tvrtko Ursulin
On 03/06/16 17:08, Chris Wilson wrote: If we convert the tracing over from direct use of ring->irq_get() and over to the breadcrumb infrastructure, we only have a single user of the ring->irq_get and so we will be able to simplify the driver routines (eliminating the redundant validation and irq

[Intel-gfx] [PATCH 17/21] drm/i915: Convert trace-irq to the breadcrumb waiter

2016-06-03 Thread Chris Wilson
If we convert the tracing over from direct use of ring->irq_get() and over to the breadcrumb infrastructure, we only have a single user of the ring->irq_get and so we will be able to simplify the driver routines (eliminating the redundant validation and irq refcounting). v2: Move to a signaling fr