Re: [Intel-gfx] [PATCH 16/43] drm/i915: rework dev->first_error locking

2011-12-14 Thread Eugeni Dodonov
On Wed, Dec 14, 2011 at 10:57, Daniel Vetter wrote: > - reduce the irq disabled section, even for a debugfs file this was > way too long. > - always disable irqs when taking the lock. > > v2: Thou shalt not mistake locking for reference counting, so: > - reference count the error_state to protec

Re: [Intel-gfx] [PATCH 16/43] drm/i915: rework dev->first_error locking

2011-12-14 Thread Chris Wilson
On Wed, 14 Dec 2011 13:57:13 +0100, Daniel Vetter wrote: > - reduce the irq disabled section, even for a debugfs file this was > way too long. > - always disable irqs when taking the lock. > > v2: Thou shalt not mistake locking for reference counting, so: > - reference count the error_state to

[Intel-gfx] [PATCH 16/43] drm/i915: rework dev->first_error locking

2011-12-14 Thread Daniel Vetter
- reduce the irq disabled section, even for a debugfs file this was way too long. - always disable irqs when taking the lock. v2: Thou shalt not mistake locking for reference counting, so: - reference count the error_state to protect from concurent freeeing. This will be only really used in th