Re: [Intel-gfx] [PATCH 15/18] drm/i915: Add a new "remapped" gtt_view

2018-07-19 Thread Chris Wilson
Quoting Ville Syrjälä (2018-07-19 21:16:20) > > > > > +} __packed; > > > > > + > > > > > +static inline void assert_intel_remapped_info_is_packed(void) > > > > > +{ > > > > > + BUILD_BUG_ON(sizeof(struct intel_remapped_info) != > > > > > 10*sizeof(unsigned int)); > > Hmm. These assert inlin

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Add a new "remapped" gtt_view

2018-07-19 Thread Ville Syrjälä
On Thu, Jul 19, 2018 at 08:46:54PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-07-19 20:33:57) > > On Thu, Jul 19, 2018 at 07:59:33PM +0100, Chris Wilson wrote: > > > Quoting Ville Syrjala (2018-07-19 19:22:11) > > > > +static struct scatterlist * > > > > +remap_pages(const dma_addr_t

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Add a new "remapped" gtt_view

2018-07-19 Thread Ville Syrjälä
On Thu, Jul 19, 2018 at 08:46:54PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-07-19 20:33:57) > > On Thu, Jul 19, 2018 at 07:59:33PM +0100, Chris Wilson wrote: > > > Quoting Ville Syrjala (2018-07-19 19:22:11) > > > > +static struct scatterlist * > > > > +remap_pages(const dma_addr_t

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Add a new "remapped" gtt_view

2018-07-19 Thread Chris Wilson
Quoting Ville Syrjälä (2018-07-19 20:33:57) > On Thu, Jul 19, 2018 at 07:59:33PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2018-07-19 19:22:11) > > > +static struct scatterlist * > > > +remap_pages(const dma_addr_t *in, unsigned int offset, > > > + unsigned int width, unsigned

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Add a new "remapped" gtt_view

2018-07-19 Thread Ville Syrjälä
On Thu, Jul 19, 2018 at 07:59:33PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2018-07-19 19:22:11) > > +static struct scatterlist * > > +remap_pages(const dma_addr_t *in, unsigned int offset, > > + unsigned int width, unsigned int height, > > + unsigned int stride, > >

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Add a new "remapped" gtt_view

2018-07-19 Thread Chris Wilson
Quoting Ville Syrjala (2018-07-19 19:22:11) > +static struct scatterlist * > +remap_pages(const dma_addr_t *in, unsigned int offset, > + unsigned int width, unsigned int height, > + unsigned int stride, > + struct sg_table *st, struct scatterlist *sg) > +{ > + un

[Intel-gfx] [PATCH 15/18] drm/i915: Add a new "remapped" gtt_view

2018-07-19 Thread Ville Syrjala
From: Ville Syrjälä To overcome display engine stride limits we'll want to remap the pages in the GTT. To that end we need a new gtt_view type which is just like the "rotated" type except not rotated. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 12 + drivers/gpu