Re: [Intel-gfx] [PATCH 14/45] drm/i915: Make engine_mask & num_engines static

2019-04-25 Thread Tvrtko Ursulin
On 25/04/2019 11:30, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-04-25 11:20:47) On 25/04/2019 10:19, Chris Wilson wrote: Having removed the urge to modify the engine_mask at runtime, we can promote the num_engines from a runtime calculation to a static and push it into the device_info t

Re: [Intel-gfx] [PATCH 14/45] drm/i915: Make engine_mask & num_engines static

2019-04-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-25 11:20:47) > > On 25/04/2019 10:19, Chris Wilson wrote: > > Having removed the urge to modify the engine_mask at runtime, we can > > promote the num_engines from a runtime calculation to a static and push > > it into the device_info tables. > > What about fused o

Re: [Intel-gfx] [PATCH 14/45] drm/i915: Make engine_mask & num_engines static

2019-04-25 Thread Tvrtko Ursulin
On 25/04/2019 10:19, Chris Wilson wrote: Having removed the urge to modify the engine_mask at runtime, we can promote the num_engines from a runtime calculation to a static and push it into the device_info tables. What about fused off engines (intel_device_info_init_mmio)? I don't see the pat

Re: [Intel-gfx] [PATCH 14/45] drm/i915: Make engine_mask & num_engines static

2019-04-25 Thread Jani Nikula
On Thu, 25 Apr 2019, Chris Wilson wrote: > Having removed the urge to modify the engine_mask at runtime, we can > promote the num_engines from a runtime calculation to a static and push > it into the device_info tables. \o/ Acked-by: Jani Nikula > > Signed-off-by: Chris Wilson > Cc: Tvrtko

[Intel-gfx] [PATCH 14/45] drm/i915: Make engine_mask & num_engines static

2019-04-25 Thread Chris Wilson
Having removed the urge to modify the engine_mask at runtime, we can promote the num_engines from a runtime calculation to a static and push it into the device_info tables. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 3 --