Re: [Intel-gfx] [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction

2015-10-13 Thread Sharma, Shashank
Regards Shashank On 10/13/2015 7:29 PM, Emil Velikov wrote: On 13 October 2015 at 14:40, Sharma, Shashank wrote: I am not sure if I915 follows a general rule of using for(...) over while(), coz I see many instances of using a while in i915_gem, i915_drv, i915_irq etc, so it should be good. I

Re: [Intel-gfx] [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction

2015-10-13 Thread Emil Velikov
On 13 October 2015 at 14:40, Sharma, Shashank wrote: > I am not sure if I915 follows a general rule of using for(...) over while(), > coz I see many instances of using a while in i915_gem, i915_drv, i915_irq > etc, so it should be good. I would see if someone else can suggest another > good reaso

Re: [Intel-gfx] [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction

2015-10-13 Thread Sharma, Shashank
Regards Shashank On 10/13/2015 6:38 PM, Emil Velikov wrote: On 10 October 2015 at 06:09, Sharma, Shashank wrote: On 10/10/2015 4:37 AM, Emil Velikov wrote: Hi Shashank, On 9 October 2015 at 20:29, Shashank Sharma wrote: CHV/BSW platform supports two different pipe level gamma correction

Re: [Intel-gfx] [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction

2015-10-13 Thread Emil Velikov
On 10 October 2015 at 06:09, Sharma, Shashank wrote: > On 10/10/2015 4:37 AM, Emil Velikov wrote: >> >> Hi Shashank, >> >> On 9 October 2015 at 20:29, Shashank Sharma >> wrote: >>> >>> CHV/BSW platform supports two different pipe level gamma >>> correction modes, which are: >>> 1. Legacy 8-bit mo

Re: [Intel-gfx] [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction

2015-10-09 Thread Sharma, Shashank
Regards Shashank On 10/10/2015 4:37 AM, Emil Velikov wrote: Hi Shashank, On 9 October 2015 at 20:29, Shashank Sharma wrote: CHV/BSW platform supports two different pipe level gamma correction modes, which are: 1. Legacy 8-bit mode 2. 10-bit CGM (Color Gamut Mapping) mode This patch does the

Re: [Intel-gfx] [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction

2015-10-09 Thread Emil Velikov
Hi Shashank, On 9 October 2015 at 20:29, Shashank Sharma wrote: > CHV/BSW platform supports two different pipe level gamma > correction modes, which are: > 1. Legacy 8-bit mode > 2. 10-bit CGM (Color Gamut Mapping) mode > > This patch does the following: > 1. Attaches Gamma property to CRTC > 3.

[Intel-gfx] [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction

2015-10-09 Thread Shashank Sharma
CHV/BSW platform supports two different pipe level gamma correction modes, which are: 1. Legacy 8-bit mode 2. 10-bit CGM (Color Gamut Mapping) mode This patch does the following: 1. Attaches Gamma property to CRTC 3. Adds the core Gamma correction function for CHV/BSW 4. Adds Gamma correction macr