Re: [Intel-gfx] [PATCH 13/18] drm/i915: Compile out engine debug for release

2018-04-26 Thread Mika Kuoppala
Chris Wilson writes: > The majority of the engine state dumping is too voluminous to be useful > outside of a controlled setup, though a few do accompany severe errors. > Keep the debug dumps next to the errors, but hide the others behind a CI > compile flag. This becomes more useful when adding

[Intel-gfx] [PATCH 13/18] drm/i915: Compile out engine debug for release

2018-04-09 Thread Chris Wilson
The majority of the engine state dumping is too voluminous to be useful outside of a controlled setup, though a few do accompany severe errors. Keep the debug dumps next to the errors, but hide the others behind a CI compile flag. This becomes more useful when adding more dumps to latency sensitive