Re: [Intel-gfx] [PATCH 13/15] drm/i915: Implement GTT variants of pread

2011-03-24 Thread Chris Wilson
On Thu, 24 Mar 2011 10:44:40 -0700, Keith Packard wrote: > On Wed, 23 Mar 2011 17:30:22 +, Chris Wilson > wrote: > > > Right, so snooped pages goes through the shmem paths, nothing changes. Not > > everything is as nice as SNB and keeping the pages in the GTT is a benefit > > for everything

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Implement GTT variants of pread

2011-03-24 Thread Keith Packard
On Wed, 23 Mar 2011 17:30:22 +, Chris Wilson wrote: > Right, so snooped pages goes through the shmem paths, nothing changes. Not > everything is as nice as SNB and keeping the pages in the GTT is a benefit > for everything else. Where's the data. -- keith.pack...@intel.com pgplGbyHNcVEY

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Implement GTT variants of pread

2011-03-23 Thread Chris Wilson
On Wed, 23 Mar 2011 10:23:46 -0700, Eric Anholt wrote: > On Tue, 22 Mar 2011 13:51:58 +, Chris Wilson > wrote: > > Signed-off-by: Chris Wilson > > Again, needs more justification. For example, I would expect us not to > bother with the GTT on SNB pread/pwrite, and just read the backing pa

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Implement GTT variants of pread

2011-03-23 Thread Eric Anholt
On Tue, 22 Mar 2011 13:51:58 +, Chris Wilson wrote: > Signed-off-by: Chris Wilson Again, needs more justification. For example, I would expect us not to bother with the GTT on SNB pread/pwrite, and just read the backing pages (they're in our cache, no need to clflush or anything) like we a

[Intel-gfx] [PATCH 13/15] drm/i915: Implement GTT variants of pread

2011-03-22 Thread Chris Wilson
Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 184 -- 1 files changed, 174 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 37a8a29..8f60bc5 100644 --- a/drivers/gpu/drm/i9