Re: [Intel-gfx] [PATCH 13/13] DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphores

2014-04-30 Thread Ben Widawsky
On Wed, Apr 30, 2014 at 08:03:27PM +0100, Chris Wilson wrote: > On Wed, Apr 30, 2014 at 11:44:47AM -0700, Ben Widawsky wrote: > > On Wed, Apr 30, 2014 at 08:13:25AM +0100, Chris Wilson wrote: > > > On Tue, Apr 29, 2014 at 02:52:40PM -0700, Ben Widawsky wrote: > > > > This appears to not actually be

Re: [Intel-gfx] [PATCH 13/13] DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphores

2014-04-30 Thread Chris Wilson
On Wed, Apr 30, 2014 at 11:44:47AM -0700, Ben Widawsky wrote: > On Wed, Apr 30, 2014 at 08:13:25AM +0100, Chris Wilson wrote: > > On Tue, Apr 29, 2014 at 02:52:40PM -0700, Ben Widawsky wrote: > > > This appears to not actually be needed on the current code. Just putting > > > it on the ML so we can

Re: [Intel-gfx] [PATCH 13/13] DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphores

2014-04-30 Thread Ben Widawsky
On Wed, Apr 30, 2014 at 08:13:25AM +0100, Chris Wilson wrote: > On Tue, Apr 29, 2014 at 02:52:40PM -0700, Ben Widawsky wrote: > > This appears to not actually be needed on the current code. Just putting > > it on the ML so we can point bug reports at it later. > > > > As pointed out by Ville, the

Re: [Intel-gfx] [PATCH 13/13] DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphores

2014-04-30 Thread Chris Wilson
On Tue, Apr 29, 2014 at 02:52:40PM -0700, Ben Widawsky wrote: > This appears to not actually be needed on the current code. Just putting > it on the ML so we can point bug reports at it later. > > As pointed out by Ville, the current code is "broken" since we do > FORCE_RESTORE, and RESTORE_INHIBI

[Intel-gfx] [PATCH 13/13] DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphores

2014-04-29 Thread Ben Widawsky
This appears to not actually be needed on the current code. Just putting it on the ML so we can point bug reports at it later. As pointed out by Ville, the current code is "broken" since we do FORCE_RESTORE, and RESTORE_INHIBIT on the same dword. Anecdotally, this seems fine. Signed-off-by: Ben W

[Intel-gfx] [PATCH 13/13] DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphores

2014-02-19 Thread Ben Widawsky
This appears to not actually be needed on the current code. Just putting it on the ML so we can point bug reports at it later. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem_context.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_context.