Re: [Intel-gfx] [PATCH 12/16] drm/915: fix relaxed tiling on gen2: tile height

2011-05-16 Thread Daniel Vetter
On Sun, May 15, 2011 at 02:58:26PM -0700, Keith Packard wrote: > I have this vague memory of some problem in the past with tiling and old > user space for Gen2 hardware. I assume that old user space will just do > bad things, but that there's nothing the kernel can do to fix it, right? Ok, I'll tr

Re: [Intel-gfx] [PATCH 12/16] drm/915: fix relaxed tiling on gen2: tile height

2011-05-15 Thread Keith Packard
On Sun, 15 May 2011 22:43:41 +0200, Daniel Vetter wrote: > No problem for old userspace. This only changes the number of rows from 32 > to 16. This value is used in the kernel to align buffers correctly, i.e. > it will save perhaps a tiny bit of gtt. Userspace on the other hand > assumed only 8 r

Re: [Intel-gfx] [PATCH 12/16] drm/915: fix relaxed tiling on gen2: tile height

2011-05-15 Thread Daniel Vetter
On Thu, May 12, 2011 at 06:13:32PM -0700, Keith Packard wrote: > On Thu, 12 May 2011 22:17:20 +0100, Chris Wilson > wrote: > > From: Daniel Vetter > > > > A tile on gen2 has a size of 2kb, stride of 128 bytes and 16 rows. > > > > Userspace was broken and assumed 8 rows. Chris Wilson noted that

Re: [Intel-gfx] [PATCH 12/16] drm/915: fix relaxed tiling on gen2: tile height

2011-05-12 Thread Keith Packard
On Thu, 12 May 2011 22:17:20 +0100, Chris Wilson wrote: > From: Daniel Vetter > > A tile on gen2 has a size of 2kb, stride of 128 bytes and 16 rows. > > Userspace was broken and assumed 8 rows. Chris Wilson noted that the > kernel unfortunately can't reliable check that because libdrm rounds >

[Intel-gfx] [PATCH 12/16] drm/915: fix relaxed tiling on gen2: tile height

2011-05-12 Thread Chris Wilson
From: Daniel Vetter A tile on gen2 has a size of 2kb, stride of 128 bytes and 16 rows. Userspace was broken and assumed 8 rows. Chris Wilson noted that the kernel unfortunately can't reliable check that because libdrm rounds up the size to the next bucket. Signed-off-by: Daniel Vetter Signed-o