Re: [Intel-gfx] [PATCH 12/14] drm/i915: unify GT/PM irq postinstall code

2013-07-10 Thread Daniel Vetter
On Wed, Jul 10, 2013 at 10:48 PM, Paulo Zanoni wrote: > Which means we're now initializing GEN6_PM* code on SNB, which seems > good. You might want to dedicate a paragraph for this on the commit > message. > > On the IRQ patches I wrote (but did not sent yet) I unified the > ILK/SNB irq_handler vf

Re: [Intel-gfx] [PATCH 12/14] drm/i915: unify GT/PM irq postinstall code

2013-07-10 Thread Paulo Zanoni
2013/7/4 Daniel Vetter : > Again extract a common helper. For the postinstall hook things are a > bit more complicated since we have more cases on ilk-hsw/vlv here. > > But since vlv was clearly broken by failing to initialize > dev_priv->gt_irq_mask correclty (mayb that explains the strange > RING

[Intel-gfx] [PATCH 12/14] drm/i915: unify GT/PM irq postinstall code

2013-07-04 Thread Daniel Vetter
Again extract a common helper. For the postinstall hook things are a bit more complicated since we have more cases on ilk-hsw/vlv here. But since vlv was clearly broken by failing to initialize dev_priv->gt_irq_mask correclty (mayb that explains the strange RING_IMR clearing in the preinstall hook