Re: [Intel-gfx] [PATCH 11/25] drm/i915/fbc: fix the FBC state checking code

2016-08-16 Thread ch...@chris-wilson.co.uk
On Mon, Aug 15, 2016 at 10:47:18PM +, Zanoni, Paulo R wrote: > Em Seg, 2016-08-15 às 21:55 +0100, Chris Wilson escreveu: > > So this change is broken as intel_fbc_pre_update() depends upon state > > derived from the pinned framebuffer object but is being called by > > intel_crtc_page_flip() bef

Re: [Intel-gfx] [PATCH 11/25] drm/i915/fbc: fix the FBC state checking code

2016-08-15 Thread Zanoni, Paulo R
Em Seg, 2016-08-15 às 21:55 +0100, Chris Wilson escreveu: > On Tue, Jan 19, 2016 at 11:35:44AM -0200, Paulo Zanoni wrote: > > > > We'll now call intel_fbc_pre_update instead of intel_fbc_deactivate > > during atomic commits. This will continue to guarantee that we > > deactivate FBC and it will al

Re: [Intel-gfx] [PATCH 11/25] drm/i915/fbc: fix the FBC state checking code

2016-08-15 Thread Chris Wilson
On Tue, Jan 19, 2016 at 11:35:44AM -0200, Paulo Zanoni wrote: > We'll now call intel_fbc_pre_update instead of intel_fbc_deactivate > during atomic commits. This will continue to guarantee that we > deactivate FBC and it will also update the state checking structures > at the correct time. Then, la

[Intel-gfx] [PATCH 11/25] drm/i915/fbc: fix the FBC state checking code

2016-01-19 Thread Paulo Zanoni
We'll now call intel_fbc_pre_update instead of intel_fbc_deactivate during atomic commits. This will continue to guarantee that we deactivate FBC and it will also update the state checking structures at the correct time. Then, later, at the point where we were calling intel_fbc_update, we'll only n