Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-12-03 Thread Jani Nikula
On Fri, 03 Dec 2021, Ville Syrjälä wrote: > On Fri, Dec 03, 2021 at 11:55:43AM +0200, Jani Nikula wrote: >> I think an insteresting question is, with all the debugfs stuff being >> static in intel_fbc.c, is the compiler actually smart enough to optimize >> the static code and data away when CONFIG

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-12-03 Thread Ville Syrjälä
On Fri, Dec 03, 2021 at 11:55:43AM +0200, Jani Nikula wrote: > On Fri, 03 Dec 2021, Ville Syrjälä wrote: > > On Thu, Nov 25, 2021 at 04:27:18PM +0200, Jani Nikula wrote: > >> On Thu, 25 Nov 2021, Tvrtko Ursulin wrote: > >> > On 25/11/2021 12:13, Ville Syrjälä wrote: > >> >> On Thu, Nov 25, 2021 a

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-12-03 Thread Jani Nikula
On Fri, 03 Dec 2021, Ville Syrjälä wrote: > On Thu, Nov 25, 2021 at 04:27:18PM +0200, Jani Nikula wrote: >> On Thu, 25 Nov 2021, Tvrtko Ursulin wrote: >> > On 25/11/2021 12:13, Ville Syrjälä wrote: >> >> On Thu, Nov 25, 2021 at 12:57:27PM +0200, Jani Nikula wrote: >> >>> On Thu, 25 Nov 2021, Vill

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-12-03 Thread Ville Syrjälä
On Thu, Nov 25, 2021 at 04:27:18PM +0200, Jani Nikula wrote: > On Thu, 25 Nov 2021, Tvrtko Ursulin wrote: > > On 25/11/2021 12:13, Ville Syrjälä wrote: > >> On Thu, Nov 25, 2021 at 12:57:27PM +0200, Jani Nikula wrote: > >>> On Thu, 25 Nov 2021, Ville Syrjälä wrote: > On Wed, Nov 24, 2021 at

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-11-25 Thread Jani Nikula
On Thu, 25 Nov 2021, Tvrtko Ursulin wrote: > On 25/11/2021 12:13, Ville Syrjälä wrote: >> On Thu, Nov 25, 2021 at 12:57:27PM +0200, Jani Nikula wrote: >>> On Thu, 25 Nov 2021, Ville Syrjälä wrote: On Wed, Nov 24, 2021 at 05:43:52PM +0200, Jani Nikula wrote: > On Wed, 24 Nov 2021, Ville S

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-11-25 Thread Tvrtko Ursulin
On 25/11/2021 12:13, Ville Syrjälä wrote: On Thu, Nov 25, 2021 at 12:57:27PM +0200, Jani Nikula wrote: On Thu, 25 Nov 2021, Ville Syrjälä wrote: On Wed, Nov 24, 2021 at 05:43:52PM +0200, Jani Nikula wrote: On Wed, 24 Nov 2021, Ville Syrjala wrote: From: Ville Syrjälä In order to encapsu

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-11-25 Thread Ville Syrjälä
On Thu, Nov 25, 2021 at 12:57:27PM +0200, Jani Nikula wrote: > On Thu, 25 Nov 2021, Ville Syrjälä wrote: > > On Wed, Nov 24, 2021 at 05:43:52PM +0200, Jani Nikula wrote: > >> On Wed, 24 Nov 2021, Ville Syrjala wrote: > >> > From: Ville Syrjälä > >> > > >> > In order to encapsulate FBC harder let

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-11-25 Thread Jani Nikula
On Thu, 25 Nov 2021, Ville Syrjälä wrote: > On Wed, Nov 24, 2021 at 05:43:52PM +0200, Jani Nikula wrote: >> On Wed, 24 Nov 2021, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > In order to encapsulate FBC harder let's just move the debugfs >> > stuff into intel_fbc.c. >> >> Mmmh, I've k

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-11-25 Thread Ville Syrjälä
On Wed, Nov 24, 2021 at 05:43:52PM +0200, Jani Nikula wrote: > On Wed, 24 Nov 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > In order to encapsulate FBC harder let's just move the debugfs > > stuff into intel_fbc.c. > > Mmmh, I've kind of moved towards a split where i915_debugfs.c an

Re: [Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-11-24 Thread Jani Nikula
On Wed, 24 Nov 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > In order to encapsulate FBC harder let's just move the debugfs > stuff into intel_fbc.c. Mmmh, I've kind of moved towards a split where i915_debugfs.c and intel_display_debugfs.c have all the debugfs boilerplate, while the imple

[Intel-gfx] [PATCH 11/20] drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c

2021-11-24 Thread Ville Syrjala
From: Ville Syrjälä In order to encapsulate FBC harder let's just move the debugfs stuff into intel_fbc.c. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_display_debugfs.c | 50 +--- drivers/gpu/drm/i915/display/intel_fbc.c | 110 +- drivers/gpu/drm/i915