Re: [Intel-gfx] [PATCH 11/15] drm/i915: Trim i915_guc_info() stack usage

2016-11-28 Thread Tvrtko Ursulin
On 28/11/2016 11:35, Chris Wilson wrote: On Mon, Nov 28, 2016 at 11:15:27AM +, Tvrtko Ursulin wrote: On 25/11/2016 09:30, Chris Wilson wrote: i915_guc_info() (part of debugfs output) tries to avoid holding struct_mutex for a long period by copying onto the stack. This causes a warning tha

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Trim i915_guc_info() stack usage

2016-11-28 Thread Chris Wilson
On Mon, Nov 28, 2016 at 11:15:27AM +, Tvrtko Ursulin wrote: > > On 25/11/2016 09:30, Chris Wilson wrote: > >i915_guc_info() (part of debugfs output) tries to avoid holding > >struct_mutex for a long period by copying onto the stack. This causes a > >warning that the stack frame is massive, so

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Trim i915_guc_info() stack usage

2016-11-28 Thread Tvrtko Ursulin
On 25/11/2016 09:30, Chris Wilson wrote: i915_guc_info() (part of debugfs output) tries to avoid holding struct_mutex for a long period by copying onto the stack. This causes a warning that the stack frame is massive, so stop doing that. We can even forgo holding the struct_mutex here as that do

[Intel-gfx] [PATCH 11/15] drm/i915: Trim i915_guc_info() stack usage

2016-11-25 Thread Chris Wilson
i915_guc_info() (part of debugfs output) tries to avoid holding struct_mutex for a long period by copying onto the stack. This causes a warning that the stack frame is massive, so stop doing that. We can even forgo holding the struct_mutex here as that doesn't serialise the values being read (and t