Re: [Intel-gfx] [PATCH 11/14] drm/i915: unify PM interrupt preinstall sequence

2013-07-09 Thread Daniel Vetter
On Mon, Jul 08, 2013 at 02:06:50PM -0300, Paulo Zanoni wrote: > 2013/7/4 Daniel Vetter : > > Since the addition of VECS we have a slightly different enable > > sequence for PM interrupts on ivb/hsw vs snb and vlv. Usually that > > will end up in hard to track down surprises. > > > > Hence unifiy th

Re: [Intel-gfx] [PATCH 11/14] drm/i915: unify PM interrupt preinstall sequence

2013-07-08 Thread Paulo Zanoni
2013/7/4 Daniel Vetter : > Since the addition of VECS we have a slightly different enable > sequence for PM interrupts on ivb/hsw vs snb and vlv. Usually that > will end up in hard to track down surprises. > > Hence unifiy things and since we have copies of this code in 3 places > now, extract it i

[Intel-gfx] [PATCH 11/14] drm/i915: unify PM interrupt preinstall sequence

2013-07-04 Thread Daniel Vetter
Since the addition of VECS we have a slightly different enable sequence for PM interrupts on ivb/hsw vs snb and vlv. Usually that will end up in hard to track down surprises. Hence unifiy things and since we have copies of this code in 3 places now, extract it into its own little helper. v3: Reba