Re: [Intel-gfx] [PATCH 11/12] drm/i915: Inline I915_INTERRUPT_ENABLE_FIX

2012-04-25 Thread Chris Wilson
On Wed, 25 Apr 2012 13:55:12 -0700, Jesse Barnes wrote: > On Tue, 24 Apr 2012 22:59:51 +0100 > Chris Wilson wrote: > > + dev_priv->irq_mask = ~(I915_ASLE_INTERRUPT | > > + I915_DISPLAY_PIPE_A_EVENT_INTERRUPT | > > + I915_DISPLAY_PIPE_B_EVENT_IN

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Inline I915_INTERRUPT_ENABLE_FIX

2012-04-25 Thread Jesse Barnes
On Tue, 24 Apr 2012 22:59:51 +0100 Chris Wilson wrote: > Since there is only one remaining user of I915_INTERRUPT_ENABLE_FIX, > expand it at the callsite. Quoting Jesse Barnes: > > "I'd really like to get rid of these defines at the top of i915_irq.c. > Some are unused and the others just make y

[Intel-gfx] [PATCH 11/12] drm/i915: Inline I915_INTERRUPT_ENABLE_FIX

2012-04-24 Thread Chris Wilson
Since there is only one remaining user of I915_INTERRUPT_ENABLE_FIX, expand it at the callsite. Quoting Jesse Barnes: "I'd really like to get rid of these defines at the top of i915_irq.c. Some are unused and the others just make you check for the right bits everytime your read the code." Signed-