Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-09 Thread Tvrtko Ursulin
On 09/02/2021 10:31, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-09 09:37:19) On 08/02/2021 10:52, Chris Wilson wrote: diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile index 35bbe2b80596..f1d009906f71 100644 --- a/drivers/gpu/drm/i915/Kconfig

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-09 09:37:19) > > On 08/02/2021 10:52, Chris Wilson wrote: > > > diff --git a/drivers/gpu/drm/i915/Kconfig.profile > > b/drivers/gpu/drm/i915/Kconfig.profile > > index 35bbe2b80596..f1d009906f71 100644 > > --- a/drivers/gpu/drm/i915/Kconfig.profile > > +++ b/driver

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-09 Thread Tvrtko Ursulin
On 08/02/2021 10:52, Chris Wilson wrote: diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile index 35bbe2b80596..f1d009906f71 100644 --- a/drivers/gpu/drm/i915/Kconfig.profile +++ b/drivers/gpu/drm/i915/Kconfig.profile @@ -1,3 +1,65 @@ +choice + prom

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-08 16:03:03) > > On 08/02/2021 15:29, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2021-02-08 14:56:31) > >> On 08/02/2021 10:52, Chris Wilson wrote: > >>> +static bool need_preempt(const struct intel_engine_cs *engine, > >>> const struct

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Tvrtko Ursulin
On 08/02/2021 15:29, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-08 14:56:31) On 08/02/2021 10:52, Chris Wilson wrote: +static bool need_preempt(const struct intel_engine_cs *engine, const struct i915_request *rq) { const struct i915_sched *se = &engi

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-08 14:56:31) > On 08/02/2021 10:52, Chris Wilson wrote: > > +static bool need_preempt(const struct intel_engine_cs *engine, > >const struct i915_request *rq) > > { > > const struct i915_sched *se = &engine->sched; > > - int last_pr

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Tvrtko Ursulin
On 08/02/2021 10:52, Chris Wilson wrote: The first "scheduler" was a topographical sorting of requests into priority order. The execution order was deterministic, the earliest submitted, highest priority request would be executed first. Priority inheritance ensured that inversions were kept at

[Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Chris Wilson
The first "scheduler" was a topographical sorting of requests into priority order. The execution order was deterministic, the earliest submitted, highest priority request would be executed first. Priority inheritance ensured that inversions were kept at bay, and allowed us to dynamically boost prio