Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-28 Thread Matheson, Annie J
niel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of >> Daniel Vetter >> Sent: Monday, September 28, 2015 12:14 PM >> To: Sharma, Shashank >> Cc: Daniel Vetter; Roper, Matthew D; Bish, Jim; Bradford, Robert; >> Smith, Gary K; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-28 Thread Sharma, Shashank
...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Matheson, Annie J; kausalmall...@gmail.com; Vetter, Daniel Subject: Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers Yep, Daniel's right; for properties that are not specific to the driver, the core core should take ca

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-28 Thread Matt Roper
im; Bradford, Robert; Smith, Gary > K; dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > Matheson, Annie J; kausalmall...@gmail.com; Vetter, Daniel > Subject: Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers > > On Sat, Sep 26, 2015 at 09:18:48PM +0530, Sh

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-28 Thread Sharma, Shashank
K; dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Matheson, Annie J; kausalmall...@gmail.com; Vetter, Daniel Subject: Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers On Sat, Sep 26, 2015 at 09:18:48PM +0530, Sharma, Shashank wrote: > On 9/23/2015 1:52

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-27 Thread Daniel Vetter
On Sat, Sep 26, 2015 at 09:18:48PM +0530, Sharma, Shashank wrote: > On 9/23/2015 1:52 PM, Sharma, Shashank wrote: > >>Since color manager properties are meant as a new standardize KMS > >>extension (we put them into the core drm_crtc_state) the get/set support > >>should also be in the core. See e.

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-26 Thread Sharma, Shashank
On 9/23/2015 1:52 PM, Sharma, Shashank wrote: Since color manager properties are meant as a new standardize KMS extension (we put them into the core drm_crtc_state) the get/set support should also be in the core. See e.g. how the rotation property is handled in drm_atomic_plane_get/set_property.

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-23 Thread Daniel Vetter
On Wed, Sep 23, 2015 at 01:52:21PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 9/22/2015 6:45 PM, Daniel Vetter wrote: > >On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote: > >>I915 driver registers gamma correction as palette correction > >>property with DRM layer. Th

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-23 Thread Sharma, Shashank
Regards Shashank On 9/22/2015 6:45 PM, Daniel Vetter wrote: On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote: I915 driver registers gamma correction as palette correction property with DRM layer. This patch adds set_property() and get_property() handlers for pipe level gamma corr

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-22 Thread Daniel Vetter
On Tue, Sep 22, 2015 at 03:15:11PM +0200, Daniel Vetter wrote: > On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote: > > I915 driver registers gamma correction as palette correction > > property with DRM layer. This patch adds set_property() and get_property() > > handlers for pipe lev

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-22 Thread Daniel Vetter
On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote: > I915 driver registers gamma correction as palette correction > property with DRM layer. This patch adds set_property() and get_property() > handlers for pipe level gamma correction. > > The set function attaches the Gamma correctio

[Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-16 Thread Shashank Sharma
I915 driver registers gamma correction as palette correction property with DRM layer. This patch adds set_property() and get_property() handlers for pipe level gamma correction. The set function attaches the Gamma correction blob to CRTC state, these values will be committed during atomic commit.